Bug 247116 - RFE: Add debug to bonding driver as module option
RFE: Add debug to bonding driver as module option
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel (Show other bugs)
4.5
All Linux
low Severity low
: ---
: ---
Assigned To: Jiri Pirko
Network QE
: FutureFeature
Depends On:
Blocks: 546624 671310 671311
  Show dependency treegraph
 
Reported: 2007-07-05 10:46 EDT by Jon Stanley
Modified: 2015-05-04 21:14 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
: 546624 671310 671311 (view as bug list)
Environment:
Last Closed: 2011-02-16 11:05:00 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Jon Stanley 2007-07-05 10:46:46 EDT
Description of problem:

Currently the only way to enable debug functionality in the bonding driver is to
modify bond_main.c and recompile.  Would like to see this as a runtime module
option.

Version-Release number of selected component (if applicable): 2.6.9-55.EL
Comment 1 Andy Gospodarek 2007-07-05 21:31:36 EDT
I took a quick stab at this and placed some test kernels here:

http://people.redhat.com/agospoda/#rhel4
Comment 2 Andy Gospodarek 2007-07-06 17:49:11 EDT
I'm building updated kernels now -- they should be ready in a few hours.

http://people.redhat.com/agospoda/#rhel4
Comment 3 Jon Stanley 2007-11-28 10:34:40 EST
Apologies for not getting back.  This looks good.
Comment 4 Andy Gospodarek 2009-10-28 14:23:09 EDT
Support for bonding debugging with the pr_debug macro is upstream:

commit 5a03cdb7f2d7ff88e50153d8c3b90a1d52dca435
Author: Holger Eitzenberger <holger@eitzenberger.org>
Date:   Tue Dec 9 23:09:22 2008 -0800

    bonding: use pr_debug instead of own macros
    
    Use pr_debug() instead of own macros.
    
    Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>

Jiri, do you want to take a look at adding this to RHEL4?
Comment 5 Jiri Pirko 2009-10-29 05:27:41 EDT
(In reply to comment #4)
> Support for bonding debugging with the pr_debug macro is upstream:
> 
> commit 5a03cdb7f2d7ff88e50153d8c3b90a1d52dca435
> Author: Holger Eitzenberger <holger@eitzenberger.org>
> Date:   Tue Dec 9 23:09:22 2008 -0800
> 
>     bonding: use pr_debug instead of own macros
> 
>     Use pr_debug() instead of own macros.
> 
>     Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> Jiri, do you want to take a look at adding this to RHEL4?  

Sure thing, looking at the code, this should be also good to backport to rhel5.
Comment 7 Vivek Goyal 2010-10-18 09:48:37 EDT
Committed in 89.45.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/
Comment 12 errata-xmlrpc 2011-02-16 11:05:00 EST
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0263.html

Note You need to log in before you can comment on or make changes to this bug.