Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://trix.fedorapeople.org/emacs-agent-shell.spec SRPM URL: https://trix.fedorapeople.org/emacs-agent-shell-0.50.1-1.fc45.src.rpm Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/10460497 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2477433-emacs-agent-shell/fedora-rawhide-x86_64/10460497-emacs-agent-shell/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
How to use emacs-agent-shell is written up here https://fedoraproject.org/wiki/SIGs/AI-ML#agent-shell
Hey Tom, The package won't load after the installation. I think the init file is missing (I can't see it in srpm). I do see "/usr/share/emacs/site-lisp/agent-shell" in my `load-path` but `M-x agent-shell` is not a command that is available. As far as I understand the init file must be present with the package to load it, see for example terraform-mode-init.el in emacs-terraform-mode [1] or php-mode-init.el in emacs-php-mode [2]. This init file is mentioned in the guidelines as well [3]. Version 0.50.1 is 3 months old, if you'd like to update the version that would be good too I think. Let me know if I'm testing it wrong and the package should in fact be loaded somehow differently. 1. https://src.fedoraproject.org/rpms/emacs-terraform-mode/tree/rawhide 2. https://src.fedoraproject.org/rpms/emacs-php-mode/tree/rawhide 3. https://docs.fedoraproject.org/en-US/packaging-guidelines/Emacs/
Spec URL: https://trix.fedorapeople.org/emacs-agent-shell.spec SRPM URL: https://trix.fedorapeople.org/emacs-agent-shell-0.56.1-1.fc45.src.rpm Thanks for pointing out the init file, I have added a simple one to load the agent-shell Source1: %{pkg}-init.el The other source has been updated.
Nice! thanks for the updates, Tom. There is a typo ("apc" -> "acp") in couple places in the spec file. Also would you like to add "%doc README.org"? I think it will be nice to have. Other than that it all looks good and works great. I'm happy to + it as soon as the typo is fixed. %doc bit is up to you.
Spec URL: https://trix.fedorapeople.org/emacs-agent-shell.spec SRPM URL: https://trix.fedorapeople.org/emacs-agent-shell-0.56.1-1.fc45.src.rpm > There is a typo ("apc" -> "acp") in couple places in the spec file. D'oh! fixed. > Also would you like to add "%doc README.org"? I think it will be nice to have. Added.
I think it's feasible that we bundle emacs-acp and emacs-shell-maker with it. Looks great. Thank you for packaging it. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later". 33 files have unknown license. Detailed output of licensecheck in /var/home/krydos/Projects/fedora-reviews/2477433-emacs-agent- shell/licensecheck.txt [-]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 60651 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: emacs-agent-shell-0.56.1-1.fc45.noarch.rpm emacs-agent-shell-0.56.1-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2wowa3wx')] checks: 32, packages: 2 emacs-agent-shell.spec: W: no-%check-section emacs-agent-shell.noarch: W: files-duplicate /usr/share/licenses/emacs-agent-shell/LICENSE.shell-maker /usr/share/licenses/emacs-agent-shell/LICENSE:/usr/share/licenses/emacs-agent-shell/LICENSE.acp 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 emacs-agent-shell.noarch: W: files-duplicate /usr/share/licenses/emacs-agent-shell/LICENSE.shell-maker /usr/share/licenses/emacs-agent-shell/LICENSE:/usr/share/licenses/emacs-agent-shell/LICENSE.acp 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 3 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/xenodium/agent-shell/archive/refs/tags/v0.56.1.tar.gz : CHECKSUM(SHA256) this package : 40043479b993cc990795af8eb2e2afd5590c735a1cc90928ddf522cc484ff695 CHECKSUM(SHA256) upstream package : 40043479b993cc990795af8eb2e2afd5590c735a1cc90928ddf522cc484ff695 https://github.com/xenodium/acp.el/archive/refs/tags/v0.12.2.tar.gz : CHECKSUM(SHA256) this package : 986f2957a05f2a59268f485eea6150b5ce23c3edb177fd75d747137d06370f87 CHECKSUM(SHA256) upstream package : 986f2957a05f2a59268f485eea6150b5ce23c3edb177fd75d747137d06370f87 https://github.com/xenodium/shell-maker/archive/refs/tags/v0.93.1.tar.gz : CHECKSUM(SHA256) this package : f9eb10723ea2b1d4196b7853215349af7cd6242d10a16727de1f197b8072255d CHECKSUM(SHA256) upstream package : f9eb10723ea2b1d4196b7853215349af7cd6242d10a16727de1f197b8072255d Requires -------- emacs-agent-shell (rpmlib, GLIBC filtered): emacs(bin) emacs-filesystem Provides -------- emacs-agent-shell: bundled(emacs-acp) bundled(emacs-shell-maker) emacs-agent-shell Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2477433 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api Disabled plugins: Ocaml, C/C++, Python, Java, PHP, fonts, R, SugarActivity, Haskell, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/emacs-agent-shell Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`