Note: Requires https://bugzilla.redhat.com/show_bug.cgi?id=2478032 to be in Fedora for this to build.

Taking this review.

Initial spec review:

> %build
> %cmake_kf6
> %cmake_build
> cd rust
> %cargo_license_summary
> %{cargo_license} > LICENSE.dependencies
> cd ..

This should be broken up:

%conf
%cmake_kf6
cd rust
%cargo_license_summary
%{cargo_license} > LICENSE.dependencies
cd ..

%build
%cmake_build

> %{_kf6_libdir}/lib%{name}.so.1
> %{_kf6_libdir}/lib%{name}.so.1.0.0

This should be something like:

%{_kf6_libdir}/lib%{name}.so.1{,.*}

(In reply to Neal Gompa from comment #3)
> 
> > %{_kf6_libdir}/lib%{name}.so.1
> > %{_kf6_libdir}/lib%{name}.so.1.0.0
> 
> This should be something like:
> 
> %{_kf6_libdir}/lib%{name}.so.1{,.*}

Alternatively, this can be:

%{_kf6_libdir}/lib%{name}.so.1
%{_kf6_libdir}/lib%{name}.so.%{version}

Spec URL: https://farchord.fedorapeople.org/reviews/cxx-rust-cssparser/cxx-rust-cssparser.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/cxx-rust-cssparser/cxx-rust-cssparser-1.0.0-1.fc44.src.rpm

Applied review comments

[fedora-review-build]

I'm running the build on copr here so we have an output from fedora-review: https://copr.fedorainfracloud.org/coprs/farchord/reviews/build/10485933/

FYI, Fedora-review is complaining about an empty license file. It is the LicenseRef-KDE-Accepted-LGPL which Fedora doesn't use anyway. I submitted a PR upstream to fix it: https://invent.kde.org/libraries/cxx-rust-cssparser/-/merge_requests/19

Review notes:

* Package follows packaging guidelines
* Package builds and installs
* Package licensing is correct and license data is installed
* No serious issues from rpmlint

PACKAGE APPROVED.

Thank you for the review, Neal

The Pagure repository was created at https://src.fedoraproject.org/rpms/cxx-rust-cssparser
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`