Bug 2479510 - Review Request: rust-kurbu5-sys - Raw FFI bindings to the MIT Kerberos libkrb5 and KDB plugin API
Summary: Review Request: rust-kurbu5-sys - Raw FFI bindings to the MIT Kerberos libkrb...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-05-18 08:31 UTC by Andreas Schneider
Modified: 2026-06-24 16:40 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-06-24 16:40:14 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Andreas Schneider 2026-05-18 08:31:25 UTC
Spec URL: https://asn.fedorapeople.org/rust-kurbu5-sys.spec
SRPM URL: https://asn.fedorapeople.org/rust-kurbu5-sys-0.1.2-1.fc45.src.rpm
Description:                                                                                   
Fedora Account System Username: asn
Co-Maintainer: abbra                                                                      
                                                                                               
Package build order:

Stage 1 (parallel) — no kurbu5 inter-deps:
  rust-kurbu5-sys, rust-kurbu5-derive,
  rust-kurbu5-kdb-derive, rust-kurbu5-kadm5-derive

Stage 2 (parallel, after 1) — needs rust-kurbu5-sys-devel:
  rust-kurbu5-rs, rust-kurbu5-kdb-sys, rust-kurbu5-kadm5-sys

Stage 3 (parallel, after 2) — needs Stage 2 -devel packages:
  rust-kurbu5-kdb-rs, rust-kurbu5-kadm5-rs

All packages are built at:
https://copr.fedorainfracloud.org/coprs/asn/kirmes/builds/

Comment 2 Fabio Valentini 2026-06-23 09:26:30 UTC
> Fedora Account System Username: abbra
> Co-Maintainer: asn

This likely won't work (at least not initially):

The person who submits the package review request needs to be the same person who requests creation of the package and who will be "main" maintainer of it. This is also enforced by the service that processes dist-git repository creation requests.

And "giving" the package to somebody else immediately after review *might* be OK but definitely not in line with the spirit of that rule.

Let me know if you are OK with "asn" being the person who will request the dist-git repo creation and who will become main admin of the package. Otherwise abbra will need to resubmit the package review requests from his own bugzilla account.

Comment 3 Andreas Schneider 2026-06-23 10:58:42 UTC
I'm fine being the main maintainer at first.

Comment 4 Fabio Valentini 2026-06-23 11:15:48 UTC
Package looks good, with one caveat: Please exclude rust2rpm.toml and rust-kurbu5-sys.spec from the built packages.

It might be good to drop these two files from upstream entirely (they're specific to Fedora downstream packaging after all), but until then, you can use this rust2rpm.toml snippet to exclude them:

```
[package]
exclude-crate-files = ["rust2rpm.toml", "rust-kurbu5-sys.spec"]
```

Comment 6 Fabio Valentini 2026-06-23 21:18:30 UTC
Thanks, looks good to me now.

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass:
   there are no tests.
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 7 Fedora Admin user for bugzilla script actions 2026-06-24 16:19:38 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-kurbu5-sys
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 8 Fedora Update System 2026-06-24 16:35:28 UTC
FEDORA-2026-311bad7901 (rust-kurbu5-sys-0.1.2-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-311bad7901

Comment 9 Fedora Update System 2026-06-24 16:40:14 UTC
FEDORA-2026-311bad7901 (rust-kurbu5-sys-0.1.2-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.