Bug 2481491 - Review Request: serenity - Quantum chemistry code
Summary: Review Request: serenity - Quantum chemistry code
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Susi Lehtola
QA Contact: Fedora Extras Quality Assurance
URL: https://www.uni-muenster.de/Chemie.oc...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-05-26 15:32 UTC by Benson Muite
Modified: 2026-05-31 15:47 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
susi.lehtola: fedora-review?


Attachments (Terms of Use)
The .spec file difference from Copr build 10513675 to 10527354 (1.62 KB, patch)
2026-05-31 04:12 UTC, Fedora Review Service
no flags Details | Diff

Description Benson Muite 2026-05-26 15:32:51 UTC
spec: https://fed500.fedorapeople.org/serenity.spec
srpm: https://fed500.fedorapeople.org/serenity-1.6.3-1.fc43.src.rpm

description:
Serenity is a quantum chemistry code originally developed in the group of
Johannes Neugebauer at the University of Münster. Serenity has a strong
focus on quantum chemical subsystem/embedding methods.

fas: fed500

Reproducible: Always

Comment 1 Fedora Review Service 2026-05-26 15:36:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10513675
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2481491-serenity/fedora-rawhide-x86_64/10513675-serenity/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Susi Lehtola 2026-05-26 16:00:51 UTC
%files data
%license LICENSE
%{_datadir}/serenitay/

this looks like a typo

Comment 3 Susi Lehtola 2026-05-26 16:01:25 UTC
I will do the review on the weekend.

Comment 5 Fedora Review Service 2026-05-31 04:12:54 UTC
Created attachment 2143511 [details]
The .spec file difference from Copr build 10513675 to 10527354

Comment 6 Fedora Review Service 2026-05-31 04:12:56 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10527354
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2481491-serenity/fedora-rawhide-x86_64/10527354-serenity/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Susi Lehtola 2026-05-31 09:40:54 UTC
Why is there a -j1 in %cmake_build?

Comment 8 Susi Lehtola 2026-05-31 09:42:16 UTC
(In reply to Susi Lehtola from comment #7)
> Why is there a -j1 in %cmake_build?

If you really need this, the recommended way is to declare

%global _smp_ncpus_max 1

Comment 9 Susi Lehtola 2026-05-31 15:47:38 UTC
The compile took 7 hours on my machine, and failed in the check phase

+ export LDFLAGS
+ LT_SYS_LIBRARY_PATH=/usr/lib64:
+ export LT_SYS_LIBRARY_PATH
+ CC=gcc
+ export CC
+ CXX=g++
+ export CXX
+ cd serenity-1.6.3
+ source serenity.sh
/var/tmp/rpm-tmp.OvLUzb: line 47: source: serenity.sh: file not found
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.OvLUzb (%check)
    Bad exit status from /var/tmp/rpm-tmp.OvLUzb (%check)


Note You need to log in before you can comment on or make changes to this bug.