Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/jelly/rebuilderd-review/fedora-rawhide-x86_64/10520250-rebuilderd/rebuilderd.spec SRPM URL: https://pkgbuild.com/~jelle/rebuilderd-0.26.0-1.fc45.src.rpm Description: Rebuilderd monitors and reproduces binary packages from source. Fedora Account System Username: jelly
Copr build: https://copr.fedorainfracloud.org/coprs/build/10521129 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2482689-rebuilderd/fedora-rawhide-x86_64/10521129-rebuilderd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
Initial spec review: > SourceLicense: GPL-3.0-or-later > License: GPL-3.0-or-later The latter tag needs to be the "compiled" license, with all statically linked dependencies... Cf. https://docs.fedoraproject.org/en-US/legal/license-field/#_no_effective_license_analysis > Source0: %{url}/archive/refs/tags/v%{version}.tar.gz Please use "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz". Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags > %autosetup -n rebuilderd-%{version} -p1 You could alternatively use "%autosetup -C -p1" if you don't need EPEL support. > %{_mandir}/man1/rebuilderd.1.* This should be ".1*", since you cannot expect an extension suffix.
Thanks for the review, I've pushed a new build to my copr repository which should address your comments. I've taken inspiration from the ruff package to resolve the Licenses issue. https://copr.fedorainfracloud.org/coprs/jelly/rebuilderd-review/build/10527912/ I'll also update the GNU hello example as it uses the same wrong man pages %install section: https://docs.fedoraproject.org/en-US/package-maintainers/Packaging_Tutorial_2_GNU_Hello/#inside_spec
(In reply to Jelle van der Waa from comment #4) > Thanks for the review, I've pushed a new build to my copr repository which > should address your comments. I've taken inspiration from the ruff package > to resolve the Licenses issue. > > https://copr.fedorainfracloud.org/coprs/jelly/rebuilderd-review/build/ > 10527912/ > Please post new Spec and SRPM URLs for updated builds, so the Review Service can pick them up.
Spec URL: https://download.copr.fedorainfracloud.org/results/jelly/rebuilderd-review/fedora-rawhide-x86_64/10527912-rebuilderd/rebuilderd.spec SRPM URL: https://pkgbuild.com/~jelle/rebuilderd-0.26.0-1.fc45.src.rpm
Spec URL: https://download.copr.fedorainfracloud.org/results/jelly/rebuilderd-review/fedora-rawhide-x86_64/10527912-rebuilderd/rebuilderd.spec SRPM URL: https://pkgbuild.com/~jelle/rebuilderd-0.26.0-1.fc45.src.rpm Description: Rebuilderd monitors and reproduces binary packages from source. Fedora Account System Username: jelly
Created attachment 2143941 [details] The .spec file difference from Copr build 10521129 to 10551645
Copr build: https://copr.fedorainfracloud.org/coprs/build/10551645 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2482689-rebuilderd/fedora-rawhide-x86_64/10551645-rebuilderd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.