Fedora Account System
Red Hat Associate
Red Hat Customer
This is a request to unretire the python-junit_xml package, which was retired approximately 9 months ago. Spec URL: https://src.fedoraproject.org/rpms/python-junit_xml/blob/f43/f/python-junit_xml.spec Upstream: https://github.com/kyrus/python-junit-xml Description: python-junit_xml is a Python module for creating JUnit XML test result documents. It is used by coreos-assembler (COSA) for generating test reports in CI pipelines. Without this package in F44, the kola-junit test reporting functionality will be unavailable once COSA rebases to Fedora 44. The existing spec file from F43 should be reusable with minimal updates. I am volunteering to maintain this package going forward. Reproducible: Always
Created attachment 2143331 [details] SRPM: python-junit_xml-1.9^20200222gitba89b41-25.fc44.src.rpm
Spec from f43 branch builds cleanly against f44 (mockbuild, Python 3.14) with no changes. SRPM attached.
Created attachment 2143837 [details] fedora-review output (fedora-rawhide-x86_64, 0 rpmlint errors/warnings)
Attached fedora-review output (fedora-rawhide-x86_64, 0 rpmlint errors/warnings). This is a re-review for unretiring the existing `python-junit_xml` package. The "package name already exists" note is expected.
Hi, I (FAS: music) maintained this package in Fedora for some time before eventually orphaning it. You should submit links to a source RPM and .spec file (not a link to a formatted HTML rendering of the spec file, but to the actual raw spec file). See https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#_contributor. If this package is to be unretired, then as long as you need a re-review, I think it should be renamed to python-junit-xml at the same time. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_library_naming and the large comment in the original spec file itself, https://src.fedoraproject.org/rpms/python-junit_xml/blob/f43/f/python-junit_xml.spec#_35-45, and see https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Process/ for general information on renaming packages. # The source package is named python-junit_xml for historical reasons. The # binary package, python3-junit-xml, is named using the canonical project # name[1]; see also [2]. # # The %%py_provides macro is used to provide an upgrade path from # python3-junit_xml and to produce the appropriate Provides for the importable # module[3]. # # [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_canonical_project_name # [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_library_naming # [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides_for_importable_modules Note also that this project has been unmaintained upstream for over five years. This doesn’t mean you can’t package it in Fedora, but it means you are on your own to fix any problems, and you should probably think carefully about whether an alternative exists. Finally, even though the package was retired in F44+ after I orphaned it, https://src.fedoraproject.org/rpms/python-junit_xml has been picked up by Steve Traylen (FAS: stevetraylen), who is presumably maintaining the F43 and EPEL10 branches. You might want to coordinate or at least give a heads-up.
> has been picked up by Steve Traylen (FAS: stevetraylen), who is presumably maintaining the F43 and EPEL10 branches I think I was only caring about the EPEL branches even if I had more permissions. I have vague memory I noticed it was orphaned but that was fine with me, I can't remember why I ever wanted this.
Hi Ben and Steve, Thank you both for the detailed feedback on the re-review. Considering the above and after discussing details with the CoreOS team, we've decided to switch from `python-junit_xml` to junitparser (actively maintained, already packaged in Fedora) instead of unretiring this package. The migration work is tracked in https://github.com/coreos/coreos-assembler/issues/4573. I'm closing this review request. Apologies for the noise, and thanks again for your time!