Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://people.redhat.com/~vkuznets/cvmutils/python-cvmutils.spec SRPM URL: https://people.redhat.com/~vkuznets/cvmutils/python-cvmutils-0.3.2-1.fc43.src.rpm Description: A set of scripts to prepare a VM image to run in a Confidential VM environment. Fedora Account System Username: vittyvk The package is supported in Fedora Copr at this moment: https://copr.fedorainfracloud.org/coprs/vittyvk/cvmutils/
Copr build: https://copr.fedorainfracloud.org/coprs/build/10551678 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2483948-python-cvmutils/fedora-rawhide-x86_64/10551678-python-cvmutils/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
DISCLAIMER: I'm not in the fedora packagers group. DO NOT CONSIDER THIS AN OFFICIAL PACKAGE REVIEW. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ====== - I'm not marking the "Package functions as described" because I can't run cvm-encrypt-image without manually installing qemu-img first. I think it should be marked as a runtime dependency. Comments ======== - Rewrite "Source:" as "%{url}/-/archive/..." instead? - Even if it is noarch I tried running mock builds for x86_64, s390x and aarch64 just in case. Those were okay. Still a bunch to cover all others, but well... ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License v2.1 or later", "*No copyright* GNU Lesser General Public License, Version 2.1". 17 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/python-cvmutils/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14/site- packages, /usr/lib/python3.14 [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 14666 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-cvmutils [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-cvmutils-0.3.2-1.fc45.noarch.rpm cvmutils-reseal-0.3.2-1.fc45.noarch.rpm python-cvmutils-0.3.2-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpinkcfa9_')] checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 11 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python3-cvmutils". (none): E: there is no installed rpm "cvmutils-reseal". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://gitlab.com/vkuznets/cvmutils/-/archive/0.3.2/cvmutils-0.3.2.tar.gz : CHECKSUM(SHA256) this package : e0e8c51bd0ca262832036abf02a61910b03227ae380e1a8826a25db52223baf1 CHECKSUM(SHA256) upstream package : e0e8c51bd0ca262832036abf02a61910b03227ae380e1a8826a25db52223baf1 Requires -------- python3-cvmutils (rpmlib, GLIBC filtered): /usr/bin/python3 cryptsetup e2fsprogs openssl python(abi) systemd-udev util-linux cvmutils-reseal (rpmlib, GLIBC filtered): /usr/bin/python3 python-cvmutils Provides -------- python3-cvmutils: python-cvmutils python3-cvmutils python3.14-cvmutils python3.14dist(cvmutils) python3dist(cvmutils) cvmutils-reseal: cvmutils-reseal
Thank you for the review! I've added qemu-img as 'Recommends:' -- strictly speaking it is not 'Required' as you can use raw images with losetup or connect images in a different way but qemu-nbd certainly makes things easier. The package is 'noarch' meaning it's pure Python but currently it can only deal with x86_64 images, it is a known limitation. Aarch64 support is expected in the future. I did not fully get the comment regarding the Source, currently it is Source: https://gitlab.com/vkuznets/cvmutils/-/archive/%version/cvmutils-%version.tar.gz I've uploaded the updated stuff to the same location: Spec URL: https://people.redhat.com/~vkuznets/cvmutils/python-cvmutils.spec SRPM URL: https://people.redhat.com/~vkuznets/cvmutils/python-cvmutils-0.3.2-1.fc43.src.rpm
(In reply to Vitaly Kuznetsov from comment #3) > Thank you for the review! I've added qemu-img as 'Recommends:' -- strictly > speaking it is not 'Required' > as you can use raw images with losetup or connect images in a different way > but qemu-nbd certainly makes > things easier. > Ack, thanks! > The package is 'noarch' meaning it's pure Python but currently it can only > deal with x86_64 > images, it is a known limitation. Aarch64 support is expected in the future. > Probably not the smartest thing that I have tried out, but for the record: mock builds were tested there too :) > I did not fully get the comment regarding the Source, currently it is > > Source: > https://gitlab.com/vkuznets/cvmutils/-/archive/%version/cvmutils-%version. > tar.gz > It was a rather minor comment so you did not have to write the root of the url, e.g. https://gitlab.com/vkuznets/cvmutils, twice. First for "Url: <>" and then for "Source: <>", when for the latter you could have just used literally %{url}/-/<whatever> instead. > I've uploaded the updated stuff to the same location: > > Spec URL: https://people.redhat.com/~vkuznets/cvmutils/python-cvmutils.spec > SRPM URL: > https://people.redhat.com/~vkuznets/cvmutils/python-cvmutils-0.3.2-1.fc43. > src.rpm
The package naming approach feels a bit off. Essentially this is just shipping two applications. The simplified package file list: %files -n python3-cvmutils %{_bindir}/cvm-encrypt-image %files -n cvmutils-reseal %{_bindir}/cvm-reseal Most notably there is no public importable module providing a library API. Thus I think this falls entirely under the "Application naming" guideline: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming IOW, I don't think we need to be using 'python3-' name prefix in any output package name. I'd say it is probably ok to use 'cvm-encrypt-image' and 'cvm-reseal' as the output package names, ie a 100% match for the single binary each one ships. Is there a need for these two small scripts to be in separate RPMs though ? If not a single output package could be merely called "cvmutils".
python3-cvmutils is actually a library which is used by both 'cvm-reseal' and 'cvm-encrypt-image' because of %{python3_sitelib}/cvmutils I've separated the packages because their usage is significantly different. 'cvm-encrypt-image' is executed in the environment where the image is prepared and 'cvm-reseal' must run on the target VM. Going forward, I expect cvm-reseal to go to the initramfs because re-sealing requires un-sealing and with the newly introduced PCR7 barrier it becomes impossible in the main system (it is a good change from security perspective). I think what we can do is create a separate 'cvm-encrypt-image' into its own package so we will have 3 packages in output: cvm-encrypt-image cvm-reseal python3-cvmutils This looks ideal from the perspective of dependencies: 'cvm-encrypt-image' may require tools we do not want to have in the target CVM. In the sources, I also have an experimental dracut module which we don't enable just yet so at the end of the day I expect the number of sub-packages to grow. While we may go with a single 'cvmutils', it will make it harder to do the split later. What do you think?
Since they are intended to be installed & used in different scenarios, I think splitting per binary is a reasonable approach.
Changed to 'python3-cvmutils'/'cvm-encrypt-image'/'cvm-reseal' naming of sub-packages. The updated specfile and the SRPM are at the original location: Spec URL: https://people.redhat.com/~vkuznets/cvmutils/python-cvmutils.spec SRPM URL: https://people.redhat.com/~vkuznets/cvmutils/python-cvmutils-0.3.2-1.fc43.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License v2.1 or later", "*No copyright* GNU Lesser General Public License, Version 2.1". 18 files have unknown license. Detailed output of licensecheck in /home/berrange/2483948-python-cvmutils/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.15, /usr/lib/python3.15/site-packages [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 14666 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-cvmutils , cvm-encrypt-image , cvm-reseal [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-cvmutils-0.3.2-1.fc45.noarch.rpm cvm-encrypt-image-0.3.2-1.fc45.noarch.rpm cvm-reseal-0.3.2-1.fc45.noarch.rpm python-cvmutils-0.3.2-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2m4votbb')] checks: 32, packages: 4 cvm-encrypt-image.noarch: E: spelling-error ('Pre', '%description -l en_US Pre -> Pr, Re, Pres') cvm-encrypt-image.noarch: E: spelling-error ('vTPM', '%description -l en_US vTPM -> Vt') cvm-reseal.noarch: E: spelling-error ('lifecycle', '%description -l en_US lifecycle -> life cycle, life-cycle, recycle') python-cvmutils.src: E: spelling-error ('pre', '%description -l en_US pre -> per, ore, pee') 4 packages and 0 specfiles checked; 4 errors, 0 warnings, 15 filtered, 4 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 3 cvm-reseal.noarch: E: spelling-error ('lifecycle', '%description -l en_US lifecycle -> life cycle, life-cycle, recycle') cvm-encrypt-image.noarch: E: spelling-error ('Pre', '%description -l en_US Pre -> Pr, Re, Pres') cvm-encrypt-image.noarch: E: spelling-error ('vTPM', '%description -l en_US vTPM -> Vt') 3 packages and 0 specfiles checked; 3 errors, 0 warnings, 11 filtered, 3 badness; has taken 0.1 s Source checksums ---------------- https://gitlab.com/vkuznets/cvmutils/-/archive/0.3.2/cvmutils-0.3.2.tar.gz : CHECKSUM(SHA256) this package : e0e8c51bd0ca262832036abf02a61910b03227ae380e1a8826a25db52223baf1 CHECKSUM(SHA256) upstream package : e0e8c51bd0ca262832036abf02a61910b03227ae380e1a8826a25db52223baf1 Requires -------- python3-cvmutils (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) cvm-encrypt-image (rpmlib, GLIBC filtered): /usr/bin/python3 cryptsetup e2fsprogs openssl python3-cvmutils systemd-udev util-linux cvm-reseal (rpmlib, GLIBC filtered): /usr/bin/python3 cryptsetup openssl python3-cvmutils systemd-udev util-linux Provides -------- python3-cvmutils: python-cvmutils python3-cvmutils python3.15-cvmutils python3.15dist(cvmutils) python3dist(cvmutils) cvm-encrypt-image: cvm-encrypt-image cvm-reseal: cvm-reseal Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2483948 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: PHP, C/C++, SugarActivity, Ocaml, Java, Perl, Haskell, fonts, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cvmutils Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-0c5e45dffc (python-cvmutils-0.3.2-1.fc46) has been submitted as an update to Fedora 46. https://bodhi.fedoraproject.org/updates/FEDORA-2026-0c5e45dffc
FEDORA-2026-0c5e45dffc (python-cvmutils-0.3.2-1.fc46) has been pushed to the Fedora 46 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-dae44016ef (python-cvmutils-0.3.2-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-dae44016ef
FEDORA-2026-dae44016ef (python-cvmutils-0.3.2-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.