Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Params-CallbackRequest/perl-Params-CallbackRequest.spec SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Params-CallbackRequest-1.17-1.src.rpm Description: Params::CallbackRequest provides functional and object-oriented callbacks to method and function parameters. Callbacks may be either code references provided to the new() constructor, or methods defined in subclasses of Params::Callback. Callbacks are triggered either for every call to the Params::CallbackRequest request() method, or by specially named keys in the parameters to request().
Got following all skipped: Testing of apache_req requires Apache::FakeRequest Can you add Apache::FakeRequest as BR?
No, that's a mod_perl 1 module. There's no Apache2 (mod_perl 2) equivalent.
you can ask then to fix this issue to upstream.
There's nothing to fix. This module works with both mod_perl 1 and 2. That test is mod_perl 1-specific.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 9db73e6e2f39cd4648ada030013414e7 Params-CallbackRequest-1.17.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs t/01basic.............ok t/02priority..........ok t/03keys..............ok t/04errors............ok t/05object............ok t/06object_request....ok t/07combined..........ok t/08apache............skipped all skipped: Testing of apache_req requires Apache::FakeRequest t/09pod...............ok All tests successful, 1 test skipped. Files=9, Tests=421, 1 wallclock secs ( 0.76 cusr + 0.10 csys = 0.86 CPU) +Provides: perl(Params::Callback) = 1.17 perl(Params::CallbackRequest) = 1.17 perl(Params::CallbackRequest::Exceptions) = 1.17 +Requires: perl(:MODULE_COMPAT_5.8.8) perl(Exception::Class) perl(Exception::Class) >= 1.10 perl(Params::CallbackRequest::Exceptions) perl(Params::Validate) perl(Params::Validate) >= 0.59 perl(constant) perl(strict) perl(vars) APPROVED.
New Package CVS Request ======================= Package Name: perl-Params-CallbackRequest Short Description: Functional and object-oriented callback architecture Owners: steve Branches: FC-6 F-7 EL-4 EL-5 InitialCC: fedora-perl-devel-list