Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://rathann.fedorapeople.org/review/rust-oncemutex/rust-oncemutex.spec SRPM URL: https://rathann.fedorapeople.org/review/rust-oncemutex/rust-oncemutex-0.1.1-1.fc45.src.rpm Description: A mutex providing one-time synchronized access, then safe lock-free access. Fedora Account System Username: rathann
Copr build: https://copr.fedorainfracloud.org/coprs/build/10579153 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2486089-rust-oncemutex/fedora-rawhide-x86_64/10579153-rust-oncemutex/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> # FIXME: no license files detected You have to actually fix this. Both MIT and Apache-2.0 licenses require distributing the license text. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text The license files aren’t present upstream in https://github.com/reem/rust-once-mutex, so you would have to first try engaging with upstream and then, if that doesn’t get anywhere, you could make a reasonable guess at the intended license text downstream. However, stepping back a bit, this is a library that hasn’t been touched in nearly 11 years, so it’s pretty clear that it’s unmaintained upstream. It is a dependency for the regex-cache crate, which (looking at https://github.com/1aim/rust-regex-cache) hasn’t been touched in six years. Looking at libphonenumber upstream, the regex-cache dependency was just removed in an unreleased commit https://github.com/whisperfish/rust-phonenumber/commit/bc696ca09f40e9d474098b2e381e87e78c50fba1. Perhaps we could avoid both rust-regex-cache and rust-oncemutex. I’m not sure if backporting that change is wise, since it breaks the public API of the phonenumber crate, but maybe the 0.4.0 release isn’t too far away?
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
I still intend to get this done.