Spec URL: http://repo.calcforge.org/f8/atlantikdesigner.spec SRPM URL: http://repo.calcforge.org/f8/atlantikdesigner-3.5.7-3.fc7.src.rpm Description: This package includes a game board designer for Atlantik. NOTE: This package is only targeted for F8 and above.
I'd feel better if this were named kdeaddons3, offers more flexibility what can be included. Then, this would simply produce (as is now): kdeaddons3-atlantikdesigner But, if you think that's just silly-talk, feel free to ignore me here.
A subpackage with no main package? Will that work? I found it's pretty silly to have a kdeaddons3 package with only a single addon in it. ;-) But I'm open to changing it.
Reviewing this, as promised. (In reply to comment #2) > A subpackage with no main package? Will that work? Yes that will work, when you have no %files for the mainpackage, no mainpackage will be build. > I found it's pretty silly to have a kdeaddons3 package with only a single addon > in it. ;-) But I'm open to changing it. I don't know whats best here, are you sure all the other addons will be available for kde4? Then I agree that atlantikdesigner is a better name.
MUST: ===== * rpmlint output is: W: atlantikdesigner obsolete-not-provided kdeaddons-atlantikdesigner * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel x86_64 * BR: ok * No locales * no Shared libraries * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed * .desktop file as required Must Fix: --------- * Add "Requires: hicolor-icon-theme" for dir ownership
I discussed the naming again with Rex Dieter on IRC, and we decided that renaming this to kdeaddons3 (and building only a kdeaddons3-atlantikdesigner subpackage) is safest in case we want to build other addons later, although still only the Atlantik Designer is built. I'm going to submit a new specfile with the new name and the missing Requires ASAP.
Updated: Spec URL: http://repo.calcforge.org/f8/kdeaddons3.spec SRPM URL: http://repo.calcforge.org/f8/kdeaddons3-3.5.7-4.fc7.src.rpm - rename (again) to kdeaddons3 - build (only) kdeaddons3-atlantikdesigner subpackage - Conflicts with pre-KDE-4 kdeaddons-extras - add Requires on hicolor-icon-theme for directory ownership - remove Requires({pre,post}): ldconfig because no shared libs are shipped
Must fix: --------- * make "%post" "%post atlantikdesigner" * idem for %postun Should fix: ----------- * Remove update-desktop-database from %post scripts, as atlantikdesigner.desktop doesn't define any mimetimes (you might want to check this for kdegames3 too)
> * make "%post" "%post atlantikdesigner" > * idem for %postun Whoops, good catch. ;-) > * Remove update-desktop-database from %post scripts, as > atlantikdesigner.desktop doesn't define any mimetimes (you might want to > check this for kdegames3 too) Oh, I wasn't aware of that one (that update-desktop-database is only needed when MIME types are touched). I'm going to remove it. Kevin Kofler
Updated: Spec URL: http://repo.calcforge.org/f8/kdeaddons3.spec SRPM URL: http://repo.calcforge.org/f8/kdeaddons3-3.5.7-5.fc7.src.rpm - fix post and postun scriptlets to run for the subpackage - don't run update-desktop-database because no MIME types are touched
APPROVED!
It turns out there will be no kdeaddons 4 (which wasn't decided/clear when I submitted this review request), so I just imported this specfile (with some changes, like renaming back to kdeaddons) into the existing kdeaddons module.