Fedora Account System
Red Hat Associate
Red Hat Customer
Created attachment 2144738 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-gen-lsp-types.spec SRPM URL: https://music.fedorapeople.org/rust-gen-lsp-types-0.8.0-1.fc44.src.rpm Description: Library of Rust LSP types generated from the official metamodel. Fedora Account System Username: music https://release-monitoring.org/project/390546/
Copr build: https://copr.fedorainfracloud.org/coprs/build/10579700 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2486510-rust-gen-lsp-types/fedora-rawhide-x86_64/10579700-rust-gen-lsp-types/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10579701 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2486510-rust-gen-lsp-types/fedora-rawhide-x86_64/10579701-rust-gen-lsp-types/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. Deviations from what rust2rpm generates are documented and justified. Ensuring that the original "source" for generated code is available is handled correctly, as far as I can tell. It *might* be possible to actually regenerate stuff at build-time ("cargo run xtask ..."), but it looks like that would pull in additional dependencies for that xtask - and I'm not sure that this would be worth the effort. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
Thank you for the review! (In reply to Fabio Valentini from comment #3) > It *might* be possible to actually regenerate stuff at build-time ("cargo > run xtask ..."), but it looks like that would pull in additional > dependencies for that xtask - and I'm not sure that this would be worth the > effort. Indeed, this is probably possible, but in addition to being a bit fussy, there’s a conflict between the two principles: - Rust crates must be built solely from crates.io sources: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_package_sources - It’s nice to re-generate pre-generated code when we can: https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#pregenerated-code In this case, the first bullet point is currently a much stronger prescription.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gen-lsp-types Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-c9d1174abb (rust-gen-lsp-types-0.8.0-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-c9d1174abb
FEDORA-2026-c9d1174abb (rust-gen-lsp-types-0.8.0-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.