Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://eseyman.fedorapeople.org/perl-HTML-Formatter/perl-HTML-Formatter.spec SRPM URL: https://eseyman.fedorapeople.org/perl-HTML-Formatter/perl-HTML-Formatter-2.16-30.fc44.src.rpm Description: A collection of modules that formats HTML as plaintext, PostScript or RTF. Fedora Account System Username: eseyman This is a re-review request, since I am renaming perl-HTML-Format to perl-HTML-Formatter.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10581258 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2486589-perl-html-formatter/fedora-rawhide-x86_64/10581258-perl-HTML-Formatter/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
- Missing BR: perl-interpreter for first line of %build - Possibly missing Requires on perl(Font::Metrics::*) as in the pre-rename specfile Other than that, looks good to me.
(In reply to Xavier Bachelot from comment #2) > > - Missing BR: perl-interpreter for first line of %build Indeed. Added. > - Possibly missing Requires on perl(Font::Metrics::*) as in the pre-rename > specfile Added. Spec URL: https://eseyman.fedorapeople.org/perl-HTML-Formatter/perl-HTML-Formatter.spec SRPM URL: https://eseyman.fedorapeople.org/perl-HTML-Formatter/perl-HTML-Formatter-2.16-31.fc44.src.rpm
Created attachment 2144923 [details] The .spec file difference from Copr build 10581258 to 10584581
Copr build: https://copr.fedorainfracloud.org/coprs/build/10584581 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2486589-perl-html-formatter/fedora-rawhide-x86_64/10584581-perl-HTML-Formatter/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Sorry, I should have been more clear, the Requires in the pre-rename package are not using a wildcard but are explicitly listing them. https://src.fedoraproject.org/rpms/perl-HTML-Format/blob/rawhide/f/perl-HTML-Format.spec#_69 ``` Requires: perl(Font::Metrics::Courier) Requires: perl(Font::Metrics::CourierBold) Requires: perl(Font::Metrics::CourierBoldOblique) Requires: perl(Font::Metrics::CourierOblique) Requires: perl(Font::Metrics::Helvetica) Requires: perl(Font::Metrics::HelveticaBold) Requires: perl(Font::Metrics::HelveticaBoldOblique) Requires: perl(Font::Metrics::HelveticaOblique) Requires: perl(Font::Metrics::TimesBold) Requires: perl(Font::Metrics::TimesBoldItalic) Requires: perl(Font::Metrics::TimesItalic) Requires: perl(Font::Metrics::TimesRoman) ```
That will teach me to handle bug reports at 2am... Spec file updated. Spec URL: https://eseyman.fedorapeople.org/perl-HTML-Formatter/perl-HTML-Formatter.spec SRPM URL: https://eseyman.fedorapeople.org/perl-HTML-Formatter/perl-HTML-Formatter-2.16-31.fc44.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 1 and/or The Perl 5 License". 45 files have unknown license. Detailed output of licensecheck in /tmp/2486589-perl-HTML- Formatter/licensecheck.txt [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/HTML(perl-HTML-TagCloud, perl-HTML- Entities-Interpolate, perl-HTML-HTML5-Parser, perl-HTML- CalendarMonthSimple, perl-HTML-Element-Extended, perl-HTML-FromText, perl-HTML-Quoted, perl-HTML-Tagset, perl-Catalyst-Controller-HTML- FormFu, perl-HTML-TokeParser-Simple, perl-HTML-SuperForm, perl-HTML- HTML5-Entities, perl-HTML-LinkList, perl-HTML-Lint, perl-HTML- Restrict, perl-HTML-SimpleParse, perl-HTML-TableExtract, perl-HTML- FormatText-WithLinks-AndTables, perl-HTML-BarGraph, perl-HTML- PrettyPrinter, perl-HTML-Template, perl-HTML-FormFu-Model-DBIC, perl- HTML-TreeBuilder-XPath, perl-HTML-Mason, perl-HTML-Encoding, perl- HTML-FormFu, perl-HTML-RewriteAttributes, perl-HTML-Template-Expr, perl-HTML-Tree, perl-HTML-Entities-Numbered, perl-HTML-WikiConverter, perl-HTML-Formatter, perl-HTML-Tiny, perl-HTML-HTML5-Writer, perl- HTML-HTML5-Sanity, perl-HTML-FormatText-WithLinks, perl-HTML- FormHandler, perl-HTML-Scrubber, perl-HTML-WikiConverter-Markdown, perl-HTML-Table, perl-HTML-Defang, perl-HTML-Mason-PSGIHandler, perl- HTML-StripScripts-Parser, perl-HTML-GenToc, perl-HTML-Toc, perl-HTML- Form, perl-HTML-Selector-XPath, perl-HTML-TreeBuilder-LibXML, perl- HTML-FormatExternal, perl-HTML-DOMbo, perl-HTML-FillInForm, perl-HTML- TreeBuilderX-ASP_NET, perl-HTML-StripScripts, perl-HTML-FormFu- MultiForm, perl-HTML-FormFu-Element-reCAPTCHA) [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10276 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-HTML-Formatter-2.16-31.fc45.noarch.rpm perl-HTML-Formatter-2.16-31.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnqn0vcw9')] checks: 32, packages: 2 perl-HTML-Formatter.noarch: E: spelling-error ('plaintext', '%description -l en_US plaintext -> plain text, plain-text, plaint ext') perl-HTML-Formatter.src: E: spelling-error ('plaintext', '%description -l en_US plaintext -> plain text, plain-text, plaint ext') perl-HTML-Formatter.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-HTML-Formatter/LICENSE 2 packages and 0 specfiles checked; 3 errors, 0 warnings, 7 filtered, 3 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 perl-HTML-Formatter.noarch: E: spelling-error ('plaintext', '%description -l en_US plaintext -> plain text, plain-text, plaint ext') perl-HTML-Formatter.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-HTML-Formatter/LICENSE 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 3 filtered, 2 badness; has taken 0.0 s Source checksums ---------------- https://cpan.metacpan.org/authors/id/N/NI/NIGELM/HTML-Formatter-2.16.tar.gz : CHECKSUM(SHA256) this package : cb0a0dd8aa5e8ba9ca214ce451bf4df33aa09c13e907e8d3082ddafeb30151cc CHECKSUM(SHA256) upstream package : cb0a0dd8aa5e8ba9ca214ce451bf4df33aa09c13e907e8d3082ddafeb30151cc Requires -------- perl-HTML-Formatter (rpmlib, GLIBC filtered): perl(:VERSION) perl(Carp) perl(Encode) perl(Font::Metrics::Courier) perl(Font::Metrics::CourierBold) perl(Font::Metrics::CourierBoldOblique) perl(Font::Metrics::CourierOblique) perl(Font::Metrics::Helvetica) perl(Font::Metrics::HelveticaBold) perl(Font::Metrics::HelveticaBoldOblique) perl(Font::Metrics::HelveticaOblique) perl(Font::Metrics::TimesBold) perl(Font::Metrics::TimesBoldItalic) perl(Font::Metrics::TimesItalic) perl(Font::Metrics::TimesRoman) perl(HTML::Element) perl(HTML::Formatter) perl(IO::File) perl(base) perl(integer) perl(parent) perl(strict) perl(utf8) perl(warnings) perl-libs Provides -------- perl-HTML-Formatter: perl(HTML::FormatMarkdown) perl(HTML::FormatPS) perl(HTML::FormatRTF) perl(HTML::FormatText) perl(HTML::Formatter) perl-HTML-Format perl-HTML-Formatter Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2486589 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Perl Disabled plugins: Java, fonts, Haskell, SugarActivity, R, Ocaml, Python, PHP, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-HTML-Formatter Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
perl-HTML-Format has been retired in rawhide and perl-HTML-Formatter has been imported.