Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://eseyman.fedorapeople.org/perl-Mad-Mapper/perl-Mad-Mapper.spec SRPM URL: https://eseyman.fedorapeople.org/perl-Mad-Mapper/perl-Mad-Mapper-0.09-1.fc44.src.rpm Description: Mad::Mapper is a base class for objects that should be stored in a persistent SQL database. Currently the supported backends are Mojo::Pg Mojo::mysql and Mojo::SQLite. These backends need to be installed separately. Fedora Account System Username: eseyman
Copr build: https://copr.fedorainfracloud.org/coprs/build/10581261 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2486593-perl-mad-mapper/fedora-rawhide-x86_64/10581261-perl-Mad-Mapper/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
- %{_mandir}/man3/Mad* could be extended to %{_mandir}/man3/Mad::Mapper* - License file is not provided by upstream, guidelines require to ping upstream about this, but given latest release is from 2016, not sure it really worth it Other than that, looks good to me.
(In reply to Xavier Bachelot from comment #2) > - %{_mandir}/man3/Mad* could be extended to %{_mandir}/man3/Mad::Mapper* Indeed. Added. Spec URL: https://eseyman.fedorapeople.org/perl-Mad-Mapper/perl-Mad-Mapper.spec SRPM URL: https://eseyman.fedorapeople.org/perl-Mad-Mapper/perl-Mad-Mapper-0.09-2.fc44.src.rpm > - License file is not provided by upstream, guidelines require to ping > upstream about this, but given latest release is from 2016, not sure it > really worth it Jan has recently merged PRs and released new versions of some of his modules so you never know. I have filed https://github.com/jhthorsen/mad-mapper/issues/7
Created attachment 2144924 [details] The .spec file difference from Copr build 10581261 to 10584616
Copr build: https://copr.fedorainfracloud.org/coprs/build/10584616 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2486593-perl-mad-mapper/fedora-rawhide-x86_64/10584616-perl-Mad-Mapper/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Artistic License 2.0", "Artistic License 2.0". 17 files have unknown license. Detailed output of licensecheck in /tmp/2486593-perl-Mad-Mapper/licensecheck.txt [-]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5351 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Mad-Mapper-0.09-2.fc45.noarch.rpm perl-Mad-Mapper-0.09-2.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1m_e0b5f')] checks: 32, packages: 2 perl-Mad-Mapper.noarch: E: spelling-error ('mysql', '%description -l en_US mysql -> MySQL, muscle, muscly') perl-Mad-Mapper.src: E: spelling-error ('mysql', '%description -l en_US mysql -> MySQL, muscle, muscly') 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 9 filtered, 2 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 perl-Mad-Mapper.noarch: E: spelling-error ('mysql', '%description -l en_US mysql -> MySQL') 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 4 filtered, 1 badness; has taken 0.0 s Source checksums ---------------- https://cpan.metacpan.org/authors/id/S/SA/SADAMS/Mad-Mapper-0.09.tar.gz : CHECKSUM(SHA256) this package : 602ffd82170e5622a0c28316813b7483dd16701f3b358bdcdb30f48e2b861e76 CHECKSUM(SHA256) upstream package : 602ffd82170e5622a0c28316813b7483dd16701f3b358bdcdb30f48e2b861e76 Requires -------- perl-Mad-Mapper (rpmlib, GLIBC filtered): perl(Mojo::Base) perl(Mojo::IOLoop) perl(Mojo::JSON) perl(Mojo::Loader) perl(Scalar::Util) perl(constant) perl-libs Provides -------- perl-Mad-Mapper: perl(Mad::Mapper) perl-Mad-Mapper Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2486593 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Perl, Generic Disabled plugins: PHP, fonts, SugarActivity, Ocaml, Python, R, C/C++, Java, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Mad-Mapper Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Released for rawhide and F44.