Fedora Account System
Red Hat Associate
Red Hat Customer
spec: https://fed500.fedorapeople.org/libpicomemo.spec srpm: https://fed500.fedorapeople.org/libpicomemo-1.2.0-1.fc43.src.rpm description: A compact and portable implementation of the cryptography required for XMPP's OMEMO (E2EE). Features - Portable: besides x86 also runs on WASM, ARM and embedded systems like the ESP32! - Compatible with other XMPP clients that support OMEMO. - Low amount of code with few dependencies. - High performance by using fast crypto when available. fas: fed500 Reproducible: Always
I'll review it.
LGTM. Here is my formal Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ^^^ false positive ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license (ISC and PD). [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format (autochangelog). [x]: Sources contain only permissible code or content. [-]: Package does not contain desktop file (not a GUI application). [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: The package is ot a rename of another package. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: No large documentation files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not test if the package functions as described. [x]: Latest version is packaged (1.2.0). [x]: Package does not include license text files separate from upstream. [-]: Sources weren't verified with gpgverify. [?]: I did not test if the package compiles and builds into binary rpms on all supported architectures. [-]: %check is not present. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libpicomemo-1.2.0-1.fc45.x86_64.rpm libpicomemo-devel-1.2.0-1.fc45.x86_64.rpm libpicomemo-1.2.0-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpoek3eviy')] checks: 32, packages: 3 libpicomemo.spec: W: no-%check-section 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 26 filtered, 0 badness; has taken 0.2 s ^^^ Unfortunately we do not run any tests which require a configured xmpp-server to run. Rpmlint (debuginfo) ------------------- Checking: libpicomemo-debuginfo-1.2.0-1.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpw9fa0i5b')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 23 filtered, 0 badness; has taken 0.4 s Source checksums ---------------- https://github.com/mierenhoop/picomemo/archive/1.2.0/picomemo-1.2.0.tar.gz : CHECKSUM(SHA256) this package : 7fe1ac66b4ac82993791d4cd5e354b5c717fb3cbfb5dfa21770806fc44ceda9d CHECKSUM(SHA256) upstream package : 7fe1ac66b4ac82993791d4cd5e354b5c717fb3cbfb5dfa21770806fc44ceda9d Requires -------- libpicomemo (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.4()(64bit) libcrypto.so.4(OPENSSL_4.0.0)(64bit) rtld(GNU_HASH) libpicomemo-devel (rpmlib, GLIBC filtered): libpicomemo(x86-64) libpicomemo.so.1()(64bit) Provides -------- libpicomemo: bundled(c25519) libpicomemo libpicomemo(x86-64) libpicomemo.so.1()(64bit) libpicomemo-devel: libpicomemo-devel libpicomemo-devel(x86-64) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2487504 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Haskell, Python, SugarActivity, Java, Ocaml, PHP, fonts, Perl, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH This package is ================ === APPROVED === ================