Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://ankursinha.fedorapeople.org/focustimer/focustimer.spec SRPM URL: https://ankursinha.fedorapeople.org/focustimer/focustimer-1.1.2-1.fc45.src.rpm Upstream URL: https://gnomepomodoro.org/ Description: This GNOME app helps to manage time according to Pomodoro Technique. It intends to improve productivity and quality of work by reminding you to take short breaks. Pomodoro Technique is based on two principles: - focusing on work for limited time, about half an hour, - clearing your mind during breaks. This workflow can improve focus, physical health and mental agility depending on how you spend your breaks and how strictly you follow the routine. Fedora Account System Username: ankursinha This is a Rename request for the former package 'gnome-pomodoro'
Dropped an e-mail to gnome-pomodoro-maintainers to let them know too.
asking upstream if they prefer a name: https://github.com/focustimerhq/FocusTimer/discussions/782
Upstream prefers focus-timer. Updated urls: Spec: https://ankursinha.fedorapeople.org/focus-timer/focus-timer.spec Srpm: https://ankursinha.fedorapeople.org/focus-timer/focus-timer-1.1.2-1.fc45.src.rpm
Spec: https://ankursinha.fedorapeople.org/focus-timer/focus-timer.spec SRPM: https://ankursinha.fedorapeople.org/focus-timer/focus-timer-1.1.3-1.fc45.src.rpm
I will take this review. If Emacs doesn't scare you, I could use a review of bug 2505245.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues ====== - The License field should include the licenses for the ogg files installed in /usr/share/focus-timer/sounds. See data/sounds/CREDITS for the licenses. - The spec file includes "Provides/Obsoletes added in F35 due to package rename". F35 was a long time ago, and nothing in Fedora Requires gnome-shell-extension-pomodoro. I suggest dropping that pair of Obsoletes & Provides. A small quote from https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages "If there is no standard naming for a package or other long term naming compatibility requirements involved with the rename, the Provides should be assumed to be deprecated and short lived and removed in the distro release after the next one (i.e., if introduced in FC-X, keep in all subsequent package revisions for distros FC-X and FC-(X+1), drop in FC-(X+2)), and the distro version where it is planned to be dropped documented in a comment in the specfile." - The new Obsoletes/Provides for gnome-pomodoro lack the comment about when they can be dropped, as described in the quote above. - If you want to do so, you can also get rid of the Epoch in this new spec file, since the name is different. To do so, simply drop the Epoch field and change the Obsoletes/Provides to: Provides: gnome-pomodoro = 1:%{version}-%{release} Obsoletes: gnome-pomodoro < 1:0.28.0-5 - This package installs a file into /usr/share/knotifications6, but does not own that directory, nor have a Requires on kf6-knotifications, which does own it. - This package Requires gnome-shell "For gnome shell extension part of gnome-pomodoro". Is there a gnome-shell extension in focus-timer? - FYI, there is now a %{_metainfodir} macro, which expands to %{_datadir}/metainfo. It could be used in this spec file, if you wish. - rpmlint complains about the lack of a man page. If you wish, one can be generated by adding "BuildRequires: help2man" and doing this at the end of %build: help2man -N -n 'Time-management app built around the Pomodoro Technique' \ redhat-linux-build/src/focus-timer > focus-timer.1 ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License, Version 3", "GNU General Public License v3.0 or later", "Creative Commons Attribution and/or Creative Commons CC0". 295 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2487902-focus- timer/licensecheck.txt Some licenses are missing. See above. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/knotifications6 See above. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. See question above. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 17334 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1054720 bytes in /usr/share I'm not sure if this is big enough to justify a separate package. [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: focus-timer-1.1.3-1.fc45.x86_64.rpm focus-timer-1.1.3-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9in_191i')] checks: 32, packages: 2 focus-timer.x86_64: W: no-manual-page-for-binary focus-timer 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 7 filtered, 0 badness; has taken 0.3 s Rpmlint (debuginfo) ------------------- Checking: focus-timer-debuginfo-1.1.3-1.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpucn7gl8i')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 focus-timer.x86_64: W: no-manual-page-for-binary focus-timer 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 9 filtered, 0 badness; has taken 0.4 s Source checksums ---------------- https://github.com/focustimerhq/FocusTimer/archive/1.1.3/FocusTimer-1.1.3.tar.gz : CHECKSUM(SHA256) this package : b50c5828f0c147938a9c7404e9c344c25448fa1edca7d1a2f4fb8b37ecfe7708 CHECKSUM(SHA256) upstream package : b50c5828f0c147938a9c7404e9c344c25448fa1edca7d1a2f4fb8b37ecfe7708 Requires -------- focus-timer (rpmlib, GLIBC filtered): dbus-common gnome-shell hicolor-icon-theme libadwaita-1.so.0()(64bit) libadwaita-1.so.0(LIBADWAITA_1_0)(64bit) libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgom-1.0.so.0()(64bit) libgraphene-1.0.so.0()(64bit) libgstcontroller-1.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgtk-4.so.1()(64bit) libjson-glib-1.0.so.0()(64bit) libjson-glib-1.0.so.0(libjson-glib-1.0.so.0)(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpeas-2.so.0()(64bit) libsqlite3.so.0()(64bit) libwayland-client.so.0()(64bit) rtld(GNU_HASH) Provides -------- focus-timer: application() application(io.github.focustimerhq.FocusTimer.desktop) focus-timer focus-timer(x86-64) gnome-pomodoro gnome-shell-extension-pomodoro metainfo() metainfo(io.github.focustimerhq.FocusTimer.metainfo.xml) Diff spec file in url and in SRPM --------------------------------- --- /home/jamesjer/2487902-focus-timer/srpm/focus-timer.spec 2026-08-04 10:53:33.599779307 -0600 +++ /home/jamesjer/2487902-focus-timer/srpm-unpacked/focus-timer.spec 2026-08-03 18:00:00.000000000 -0600 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.4) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global uuid pomodoro.in %global forgeurl https://github.com/focustimerhq/FocusTimer @@ -105,3 +115,12 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Tue Aug 04 2026 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur> - 1:1.1.3-1 +- Uncommitted changes + +* Thu Jun 11 2026 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur> - 1:1.1.2-2 +- feat: renamed to focus-timer as per upstream's preference + +* Thu Jun 11 2026 Ankur Sinha (Ankur Sinha Gmail) <sanjay.ankur> - 1:1.1.2-1 +- feat: initial spec +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2487902 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Perl, Haskell, SugarActivity, PHP, Python, fonts, Ruby, Java, Ocaml, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thanks for the review, and apologies for the delay. Upstream has split out the extension into a different repository now, so this is now a DE agnostic app. I've dropped the gnome-shell requirement. New spec/srpm: Spec: https://ankursinha.fedorapeople.org/focus-timer/focus-timer.spec SRPM: https://ankursinha.fedorapeople.org/focus-timer/focus-timer-1.1.3-1.fc46.src.rpm Updated: - generate man page - drop older obsoletes - drop epoch - comment current rename obsoletes - use macros - update licenses to include sound files - use new upstream description - update dependencies
That looks great. This package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/focus-timer Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`