Bug 2489101 - Review Request: rust-async-graphql-parser - GraphQL query parser for async-graphql
Summary: Review Request: rust-async-graphql-parser - GraphQL query parser for async-gr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2489099
Blocks: 2489102
TreeView+ depends on / blocked
 
Reported: 2026-06-16 08:41 UTC by Ben Beasley
Modified: 2026-06-22 14:01 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-06-22 14:01:14 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2026-06-16 08:41:21 UTC
Spec URL: https://music.fedorapeople.org/rust-async-graphql-parser.spec
SRPM URL: https://music.fedorapeople.org/rust-async-graphql-parser-7.2.1-1.fc44.src.rpm
Description: GraphQL query parser for async-graphql.
Fedora Account System Username: music

This is a dependency for rust-cargo-semver-checks (cargo-semver-checks → trustfall → trustfall_core → async-graphql-parser).

Comment 1 Ben Beasley 2026-06-16 19:18:12 UTC
https://release-monitoring.org/project/390649/

Comment 2 Fabio Valentini 2026-06-22 13:32:41 UTC
Package looks good to me, with one minor issue:

There are two test files which are MIT-only licensed - it might make sense to just %exclude all "*.graphql" files from "tests/" so the package License tag doesn't need to be adapted to add "AND MIT" just because of test input data:

- tests/executables/kitchen-sink.graphql
- tests/services/kitchen-sink.graphql

Since this is a simple change, I trust that you can do that before importing the package.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Ben Beasley 2026-06-22 13:38:31 UTC
Thank you for the review!

(In reply to Fabio Valentini from comment #2)
> Package looks good to me, with one minor issue:
> 
> There are two test files which are MIT-only licensed - it might make sense
> to just %exclude all "*.graphql" files from "tests/" so the package License
> tag doesn't need to be adapted to add "AND MIT" just because of test input
> data:
> 
> - tests/executables/kitchen-sink.graphql
> - tests/services/kitchen-sink.graphql
> 
> Since this is a simple change, I trust that you can do that before importing
> the package.

Good catch! Thank you. As you suggested, I will use exclude-crate-files in rust2rpm.toml to omit .graphql files from the binary packages.

Comment 4 Fedora Admin user for bugzilla script actions 2026-06-22 13:39:46 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-async-graphql-parser
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 5 Fedora Update System 2026-06-22 13:56:21 UTC
FEDORA-2026-aab3afa39a (rust-async-graphql-parser-7.2.1-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-aab3afa39a

Comment 6 Fedora Update System 2026-06-22 14:01:14 UTC
FEDORA-2026-aab3afa39a (rust-async-graphql-parser-7.2.1-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.