Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://cqi.fedorapeople.org/fedora-packages/python-agent-client-protocol/python-agent-client-protocol.spec SRPM URL: https://cqi.fedorapeople.org/fedora-packages/python-agent-client-protocol/python-agent-client-protocol-0.9.0-1.fc45.src.rpm Description: Build ACP-compliant agents and clients in Python with generated schema models, asyncio transports, helper builders, and runnable demos. Fedora Account System Username: cqi
A successful Copr build: https://copr.fedorainfracloud.org/coprs/cqi/hermes-agent/build/10577138/
Copr build: https://copr.fedorainfracloud.org/coprs/build/10617513 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2490735-agent-client-protocol/fedora-rawhide-x86_64/10617513-python-agent-client-protocol/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/10794250 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2490735-python-agent-client-protocol/fedora-rawhide-x86_64/10794250-python-agent-client-protocol/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec sanity: 1. Summary ends with a dot: "Python SDK for ACP clients and agents." rpmlint flags this as summary-ended-with-dot. Remove the trailing period. 2. Description line is too long (rpmlint description-line-too-long). The single-line %_description should be wrapped to fit within 79 characters. 3. Only %pyproject_check_import is used in %check, but upstream has a pytest test suite with tests in tests/, e.g. via %pytest --ignore tests/real_user 4. I do not understand the "Exclude extra logfire, hermes-agent does not rely on it." comment. If you choose not to *package* the logfire extra, it should be due to missing dependencies, and the comment should probably go elsewhere. 5. Version 0.9.0 is packaged, but 0.11.1 is the latest on PyPI. Consider updating. 6. Consider a Source URL that has the project name in the filename, e.g. https://github.com/agentclientprotocol/python-sdk/archive/%{version}/python-sdk-%{version}.tar.gz Otherwise, the package seems well-structured and follows the guidelines.