Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://cqi.fedorapeople.org/fedora-packages/python-parallel-web/python-parallel-web.spec SRPM URL: https://cqi.fedorapeople.org/fedora-packages/python-parallel-web/python-parallel-web-0.4.2-1.fc45.src.rpm Description: The Parallel Python library provides convenient access to the Parallel REST API from any Python 3.9+ application. The library includes type definitions for all request params and response fields, and offers both synchronous and asynchronous clients powered by httpx. The REST API documentation can be found on docs.parallel.ai. The full API of this library can be found in api.md. Fedora Account System Username: cqi
Copr build: https://copr.fedorainfracloud.org/coprs/build/10621515 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491132-python-parallel-web/fedora-rawhide-x86_64/10621515-python-parallel-web/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Instead of creating a patch to relax requirements, you can use: %prep ,,, %pyproject_patch_dependency hatchling:drop_upper For the documentation see https://src.fedoraproject.org/rpms/pyproject-rpm-macros/blob/rawhide/f/README.md Or you can use 'pyp2spec --declarative-buildsystem parallel_web' to generate the spec file with declarative macros. This is just a recommendation; the use of a patch is correct as well. On the same page you can check the "Provisional: Declarative Buildsystem (RPM 4.20+)" that can significantly simplify the spec file. Is there a reason to NOT package aiohttp subpackage? If there are deps missing, I would like to see a comment that describes what is missing. This is blocking question for the review. Besides that, I found no other issue.
(In reply to Miroslav Suchý from comment #2) > Instead of creating a patch to relax requirements, you can use: > > %prep > ,,, > %pyproject_patch_dependency hatchling:drop_upper Fixed by using this. > > Is there a reason to NOT package aiohttp subpackage? If there are deps > missing, I would like to see a comment that describes what is missing. > This is blocking question for the review. > Added a comment in the SPEC. Thanks for your review. PTAL.
Hi Miroslav, PTAL when you get a chance. Thanks.