Bug 249125 - Review Request: exempi - Library for easy parsing of XMP metadata
Summary: Review Request: exempi - Library for easy parsing of XMP metadata
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-07-21 02:07 UTC by Deji Akingunola
Modified: 2007-11-30 22:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-07-29 23:15:31 UTC
Type: ---
Embargoed:
j: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Deji Akingunola 2007-07-21 02:07:07 UTC
Spec URL: ftp://czar.eas.yorku.ca/pub/exempi/exempi.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/exempi/exempi-1.99.3-1.fc8.src.rpm
Description: Exempi provides a library for easy parsing of XMP metadata. It is a port of 
Adobe XMP SDK to work on UNIX and to be build with GNU automake.
It includes XMPCore and XMPFiles.

Comment 1 Jason Tibbitts 2007-07-29 17:44:07 UTC
I have to admit that I have no idea what this package does, and no way to test
it as it's a library that has no test suite.  But it's a simple and clean
package, so...

rpmlint says:
W: exempi unused-direct-shlib-dependency /usr/lib64/libexempi.so.2.3.0 
    /lib64/libm.so.6
  It links against libm (which seems to be the default for autoconf packages) 
  but doesn't call any functions from it.  I don't see this as a really big 
  deal.

W: exempi-devel no-documentation
  Not a problem.  I guess it would be nice if there were some programming 
  information included, but it's not your responsibility to produce it.

Review:
* source files match upstream:
   f1783d5a85ec81cb3a7be3ce24fd2178e1acbc5229c719c1496160d62f57a104  
   exempi-1.99.3.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
  exempi-1.99.3-1.fc8.x86_64.rpm
   libexempi.so.2()(64bit)
   exempi = 1.99.3-1.fc8
  =
   /sbin/ldconfig
   libexempi.so.2()(64bit)
   libexpat.so.0()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)

  exempi-devel-1.99.3-1.fc8.x86_64.rpm
   exempi-devel = 1.99.3-1.fc8
  =
   exempi = 1.99.3-1.fc8
   libexempi.so.2()(64bit)
   pkgconfig

* %check is not present; no test suite upstream.
* shared libraries present; ldconfig is called as necessary and unversioned .so 
   files are in the -devel subpackage.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (ldconfig)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel subpackage.
* pkgconfig file is in the -devel subpackage; pkgconfig dependency is there.
* no static libraries.
* no libtool .la files.

APPROVED

Comment 2 Deji Akingunola 2007-07-29 19:17:43 UTC
Thanks for doing the review. XMP is the Adobe's extensible metadata platform,
and exempi provides the library for extracting the metadata under linux. New
version of tracker support it and uses exempi for the job.  

Comment 3 Deji Akingunola 2007-07-29 19:19:13 UTC
New Package CVS Request
=======================
Package Name: exempi
Short Description: Library for easy parsing of XMP metadata
Owners: dakingun
Branches: FC-6 F-7
InitialCC: 

Comment 4 Jason Tibbitts 2007-07-29 19:26:01 UTC
CVS done.

Comment 5 Deji Akingunola 2007-07-29 23:15:31 UTC
Built successfully in koji.


Note You need to log in before you can comment on or make changes to this bug.