Red Hat Bugzilla – Bug 249126
Review Request: flagpoll - Developers' tool for storing compilation information
Last modified: 2007-11-30 17:12:10 EST
Spec URL: ftp://czar.eas.yorku.ca/pub/flagpoll/flagpoll.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/flagpoll/flagpoll-0.8.3-1.fc8.src.rpm Description: Flagpoll is a tool for developers to use meta-data files for storing information on what is needed to compile their software. Think of it as the rpm of software development. It enables developers total control over which packages, versions, architectures, etc. that they want to use meta-data from.
looks upstream got new release. If you still want to contribute this package to Fedora then I will review this provided you give new SPEC and SRPM links of new upstream release. Also, make sure to use valid License names. You can use rpmlint command to check for any warnings or error messages on SRPM and RPM.
Updated package at, Spec URL: ftp://czar.eas.yorku.ca/pub/flagpoll/flagpoll.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/flagpoll/flagpoll-0.9.1-1.fc8.src.rpm
thanks. will do complete review.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. c4ac50ae99a880704abfc62a64ed16aa flagpoll-0.9.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + package flagpoll-0.9.1-1.fc8 -> Requires: /usr/bin/python automake17 + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: flagpoll Short Description: Developers' tool for storing compilation information Owners: deji Branches: F-7 InitialCC: Cvsextras Commits: yes
I assume the ' in the Description was a typo? I added it without that in the Description. cvs done.
If this is built already can we have this review CLOSED?