Bug 249212 - Review Request: inchi - The IUPAC International Chemical Identifier library
Review Request: inchi - The IUPAC International Chemical Identifier library
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Warren Togami
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2007-07-22 14:32 EDT by Dominik 'Rathann' Mierzejewski
Modified: 2007-12-12 14:33 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-11-08 14:01:08 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wtogami: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Dominik 'Rathann' Mierzejewski 2007-07-22 14:32:33 EDT
Spec URL: http://rpm.greysector.net/extras/inchi.spec
SRPM URL: http://rpm.greysector.net/extras/inchi-1.0.1-8.src.rpm
The IUPAC International Chemical Identifier (InChITM) is a non-proprietary identifier for chemical substances that can be used in printed and electronic data sources thus enabling easier linking of diverse data compilations. It was developed under IUPAC Project 2000-025-1-800 during the period 2000-2004. Details of the project and the history of its progress are available from the project web site.

This was originally built from sources included in openbabel. Release 8 is necessary to maintain a proper upgrade path. I have a pending change for openbabel in devel to build against this already.
Comment 1 Warren Togami 2007-07-24 14:23:29 EDT
> License: LGPL
Not necessary to do this in the -devel package.

> If you are going to develop programs which will use this library
> you should install inchi-devel.  You'll also need to have the
> inchi package installed.

Is this part necessary?

Licensing is confusing...
- It implies trademark integrity within the context of copyright terms.
- It implies a "request" of copyright advertisement clause, but it seems
non-binding by this language.  Is this the intent?
- None of the source files contain proper copyright notices.

1) Upstream should clear up this confusion by creating a clear separation
between the copyright and trademark rights.  Copyright explicitly LGPL, and have
a separate page/file containing the trademark guidelines.

As an example, Mozilla uses a trademark guideline to protect the integrity of
their mark, without running afoul of the (L)GPL requirement of "no additional
restrictions" on the copyright.

2) All source files must contain a proper and explicit copyright notice.  To
quote LGPL: " You must give prominent notice with each copy of the work that the
Library is used in it and that the Library and its use are covered by this
License."  Under the terms of the LGPL, those copyright statements would of
course not be removed by others.
Comment 2 Dominik 'Rathann' Mierzejewski 2007-08-12 06:09:43 EDT
Will this reply:
suffice to get this review a green light?
Comment 3 Warren Togami 2007-08-13 09:44:38 EDT
Given that this package is fine split, I'd rather wait until the upstream source
is fully fixed and explicitly clarified before approving this.  IANAL, but
upstream merely stating "go ahead" doesn't satisfy #2 above.
Comment 5 Warren Togami 2007-09-19 19:16:58 EDT
Excellent, the licensing is FAR less confusing and explicit now.

Possibly a few more issues to deal with before approval:
[builder1@newcaprica x86_64]$ rpmlint inchi-1.0.2-0.1.fc8.x86_64.rpm 
inchi.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/inchi-1.0.2/LICENSE
inchi.x86_64: W: wrong-file-end-of-line-encoding
inchi.x86_64: W: dangling-relative-symlink /usr/lib64/libinchi.so.1
inchi.x86_64: W: invalid-license LGPL
inchi.x86_64: E: invalid-ldconfig-symlink /usr/lib64/libinchi.so.1.02.00

The invalid-license warning is a must fix.  Please refer to the licensing
guidelines to use a label that is more specific to the LGPL license and version.

The symlink warning and errors are possibly suspect, please look into that.
Comment 6 Warren Togami 2007-10-01 11:49:28 EDT
Comment 8 Dominik 'Rathann' Mierzejewski 2007-10-23 17:59:15 EDT
Comment 9 Warren Togami 2007-10-24 17:29:35 EDT
OK, everything is fixed and rpmlint is completely silent.  Good job.

Comment 10 Dominik 'Rathann' Mierzejewski 2007-10-24 18:42:39 EDT
New Package CVS Request
Package Name: inchi
Short Description: The IUPAC International Chemical Identifier library
Owners: rathann
Branches: F-8 F-7
Cvsextras Commits: yes
Comment 11 Dominik 'Rathann' Mierzejewski 2007-10-24 18:43:15 EDT
Thanks for the review!
Comment 12 Kevin Fenzi 2007-10-24 20:58:39 EDT
cvs done.
Comment 13 Dominik 'Rathann' Mierzejewski 2007-11-08 14:01:08 EST
Built for devel. Builds for other branches will follow after I've updated openbabel.
Comment 14 Dominik 'Rathann' Mierzejewski 2007-12-12 08:02:50 EST
Package Change Request
Package Name: inchi
New Branches: EL-5
Comment 15 Kevin Fenzi 2007-12-12 14:33:15 EST
cvs done.

Note You need to log in before you can comment on or make changes to this bug.