Bug 2493460 - Review Request: cython-cmake - CMake helpers for building Cython modules
Summary: Review Request: cython-cmake - CMake helpers for building Cython modules
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/scikit-build/cytho...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-06-26 14:27 UTC by Cristian Le
Modified: 2026-07-08 10:33 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-07-08 10:33:43 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Cristian Le 2026-06-26 14:27:48 UTC
Spec URL: https://lecris.fedorapeople.org/reviews/cython-cmake/cython-cmake.spec
SRPM URL: https://lecris.fedorapeople.org/reviews/cython-cmake/cython-cmake-0.2.2-1.fc45.src.rpm

Description:
This provides helpers for using Cython. Use:

find_package(Cython MODULE REQUIRED VERSION 3.0)
include(UseCython)


CMake module files.

Fedora Account System Username: lecris


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=147055958

Comment 1 Fedora Review Service 2026-06-26 14:32:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10653189
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2493460-cython-cmake/fedora-rawhide-x86_64/10653189-cython-cmake/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Zbigniew Jędrzejewski-Szmek 2026-07-08 10:03:12 UTC
+ package name is OK
+ latest version (0.2.2)
+ license is acceptable for Fedora (Apache-2.0)
+ license is specified correctly
+ mock build done in copr
+ standard pyproject python packaging is used
+ %check is present and passes
+ %description is short but useful

rpmlint:
> python3-cython-cmake.noarch: W: no-manual-page-for-binary cython-cmake
> python3-cython-cmake.noarch: W: no-documentation
OK :(

> cython-cmake.noarch: E: devel-dependency python3-devel
OK in this case.

> python3-cython-cmake.noarch: W: dangling-relative-symlink /usr/lib/python3.15/site-packages/cython_cmake/cmake/FindCython.cmake ../../../../../share/cmake/Modules/FindCython.cmake
> python3-cython-cmake.noarch: W: dangling-relative-symlink /usr/lib/python3.15/site-packages/cython_cmake/cmake/UseCython.cmake ../../../../../share/cmake/Modules/UseCython.cmake
python3-cython-cmake.noarch requires the main package, so the symlink is always valid.

Package is APPROVED.

Comment 3 Cristian Le 2026-07-08 10:13:02 UTC
Thank you for the review, Zbigniew :)

Comment 4 Fedora Admin user for bugzilla script actions 2026-07-08 10:13:12 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/cython-cmake
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 6 Fedora Update System 2026-07-08 10:29:53 UTC
FEDORA-2026-918f9c406c (cython-cmake-0.2.2-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-918f9c406c

Comment 7 Fedora Update System 2026-07-08 10:33:43 UTC
FEDORA-2026-918f9c406c (cython-cmake-0.2.2-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.