Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://wojnilowicz.fedorapeople.org/python-persist-queue.spec SRPM URL: https://wojnilowicz.fedorapeople.org/python-persist-queue-1.1.0-1.fc44.src.rpm Upstream URL: https://github.com/peter-wangxu/persist-queue Description: persist-queue implements file-based and SQLite3-based persistent queues for Python. It provides thread-safe, disk-based queue implementations that survive process crashes and restarts. Fedora Account System Username: wojnilowicz
Copr build: https://copr.fedorainfracloud.org/coprs/build/10654038 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2493698-python-persist-queue/fedora-rawhide-x86_64/10654038-python-persist-queue/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-persist-queue Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Comments: - Please add comments to the manual BR. Why are they not detected by %pyproject_buildrequires? - Requires are redundant, these are automatically generated. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-persist-queue See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License". 45 files have unknown license. Detailed output of licensecheck in /home/iucar/fedora-review/2493698-python-persist- queue/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.15, /usr/lib/python3.15/site-packages [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30273 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-persist-queue , python3-persist-queue+extra , python3-persist- queue+async [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 6.7 starting (python version = 3.14.5, NVR = mock-6.7-1.fc44), args: /usr/libexec/mock/mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True --resultdir=/home/iucar/fedora-review/2493698-python-persist-queue/results install /home/iucar/fedora-review/2493698-python-persist-queue/results/python3-persist-queue+extra-1.1.0-1.fc45.noarch.rpm /home/iucar/fedora-review/2493698-python-persist-queue/results/python3-persist-queue+async-1.1.0-1.fc45.noarch.rpm /home/iucar/fedora-review/2493698-python-persist-queue/results/python3-persist-queue-1.1.0-1.fc45.noarch.rpm Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Mock Version: 6.7 INFO: Mock Version: 6.7 Start(bootstrap): chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: Package manager dnf5 detected and used (fallback) Finish(bootstrap): chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin INFO: Package manager dnf5 detected and used (direct choice) Finish: chroot init INFO: installing package(s): /builddir/python3-persist-queue+extra-1.1.0-1.fc45.noarch.rpm /builddir/python3-persist-queue+async-1.1.0-1.fc45.noarch.rpm /builddir/python3-persist-queue-1.1.0-1.fc45.noarch.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 367d11df9ddb4b75a109298fde1ede36 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.l_g9lr62:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 45 install /builddir/python3-persist-queue+extra-1.1.0-1.fc45.noarch.rpm /builddir/python3-persist-queue+async-1.1.0-1.fc45.noarch.rpm /builddir/python3-persist-queue-1.1.0-1.fc45.noarch.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts Rpmlint ------- Checking: python3-persist-queue-1.1.0-1.fc45.noarch.rpm python3-persist-queue+extra-1.1.0-1.fc45.noarch.rpm python3-persist-queue+async-1.1.0-1.fc45.noarch.rpm python-persist-queue-1.1.0-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpm9yaaoiu')] checks: 32, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 26 filtered, 0 badness; has taken 0.7 s Source checksums ---------------- https://github.com/peter-wangxu/persist-queue/archive/v1.1.0/python-persist-queue-1.1.0.tar.gz : CHECKSUM(SHA256) this package : 32bae929ec51d495e71ac9322d89ce37f5a99d4a7eeb82abedbb9d232502b3db CHECKSUM(SHA256) upstream package : 32bae929ec51d495e71ac9322d89ce37f5a99d4a7eeb82abedbb9d232502b3db Requires -------- python3-persist-queue (rpmlib, GLIBC filtered): python(abi) python3-persist-queue+extra (rpmlib, GLIBC filtered): python(abi) python3-persist-queue python3.15dist(cbor2) python3.15dist(dbutils) python3.15dist(msgpack) python3.15dist(pymysql) python3-persist-queue+async (rpmlib, GLIBC filtered): python(abi) python3-persist-queue python3.15dist(aiofiles) python3.15dist(aiosqlite) Provides -------- python3-persist-queue: python-persist-queue python3-persist-queue python3.15-persist-queue python3.15dist(persist-queue) python3dist(persist-queue) python3-persist-queue+extra: python-persist-queue+extra python3-persist-queue+extra python3.15-persist-queue+extra python3.15dist(persist-queue[extra]) python3dist(persist-queue[extra]) python3-persist-queue+async: python-persist-queue+async python3-persist-queue+async python3.15-persist-queue+async python3.15dist(persist-queue[async]) python3dist(persist-queue[async]) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2493698 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: PHP, Ocaml, Java, R, C/C++, Perl, fonts, SugarActivity, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
(In reply to Iñaki Ucar from comment #2) > Comments: > > - Please add comments to the manual BR. Why are they not detected by > %pyproject_buildrequires? Done. > - Requires are redundant, these are automatically generated. Ok, I removed them. I saw that you got errors while installing python3-persist-queue+extra. It's due to missing dependencies. I had to disable it. Does it look good to you now? [fedora-review-service-build]
Created attachment 2147076 [details] The .spec file difference from Copr build 10654038 to 10660898
Copr build: https://copr.fedorainfracloud.org/coprs/build/10660898 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2493698-python-persist-queue/fedora-rawhide-x86_64/10660898-python-persist-queue/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-persist-queue Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.