Bug 2494274 - Review Request: rust-jsonc-parser - JSONC parser
Summary: Review Request: rust-jsonc-parser - JSONC parser
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/jsonc-parser
Whiteboard:
Depends On:
Blocks: 2494288
TreeView+ depends on / blocked
 
Reported: 2026-06-29 14:18 UTC by Zbigniew Jędrzejewski-Szmek
Modified: 2026-06-29 20:43 UTC (History)
1 user (show)

Fixed In Version: rust-jsonc-parser-0.32.4-1.fc45
Clone Of:
Environment:
Last Closed: 2026-06-29 20:43:56 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Zbigniew Jędrzejewski-Szmek 2026-06-29 14:18:22 UTC
Spec URL: https://zbyszek.fedorapeople.org/rust-jsonc-parser.spec
SRPM URL: https://zbyszek.fedorapeople.org/rust-jsonc-parser-0.32.4-1.fc45.src.rpm
Upstream URL: https://crates.io/crates/jsonc-parser

Description:
JSONC parser.

Fedora Account System Username: zbyszek

Comment 1 Zbigniew Jędrzejewski-Szmek 2026-06-29 14:18:54 UTC
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=147191748

Comment 2 Fedora Review Service 2026-06-29 14:23:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10660860
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2494274-rust-jsonc-parser/fedora-rawhide-x86_64/10660860-rust-jsonc-parser/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2026-06-29 18:59:43 UTC
LGTM

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged (spec & crates.io: 0.32.4)
✅ license matches upstream specification and is acceptable for Fedora (spec & Cargo.toml: MIT)
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: jsonc-parser
  homepage: https://crates.io/crates/jsonc-parser
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-jsonc-parser

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Admin user for bugzilla script actions 2026-06-29 20:12:06 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-jsonc-parser
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 5 Zbigniew Jędrzejewski-Szmek 2026-06-29 20:13:20 UTC
Thanks!

I added the project to release-monitoring.org as "jsonc-parser",
even though the same project already exists as a python project.
I hope that was DRTTD.


Note You need to log in before you can comment on or make changes to this bug.