Bug 249532 - rpm-spec-mode.el not working?
rpm-spec-mode.el not working?
Status: CLOSED DUPLICATE of bug 227418
Product: Fedora
Classification: Fedora
Component: emacs (Show other bugs)
rawhide
All Linux
low Severity low
: ---
: ---
Assigned To: Chip Coldwell
Fedora Extras Quality Assurance
:
Depends On: 227418
Blocks:
  Show dependency treegraph
 
Reported: 2007-07-25 09:32 EDT by Neal Becker
Modified: 2007-11-30 17:12 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-11-28 08:49:23 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
rpm-spec-mode as a real compilation mode (47.98 KB, text/plain)
2007-09-10 09:33 EDT, Chip Coldwell
no flags Details
rpm-spec-mode using a real compilation mode (50.23 KB, text/x-emacs-lisp)
2007-11-28 10:23 EST, Chip Coldwell
no flags Details

  None (edit)
Description Neal Becker 2007-07-25 09:32:53 EDT
Description of problem:

Does rpm-spec-mode work for you?  I'm using current emacs devel spec file, but 
with emacs cvs source.  Using \c-c \c-b a (build all) gives nasty error.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Yoshinori KUNIGA 2007-08-02 03:43:29 EDT
Some commands including 'C-c C-b i' and 'C-c C-b p' works fine by
applying patch of bugzilla #227418.

But 'C-e C-e' does not work with following message.

  Invalid function: ignore-errors
Comment 2 Tom Tromey 2007-09-09 01:51:33 EDT
That is odd since, AFAICT, ignore-errors is autoloaded from cl-macs.
(And, if not, there's a compatibility defmacro in rpm-spec-mode.el.)
Maybe try (require 'cl-macs).
Comment 3 Chip Coldwell 2007-09-10 09:33:58 EDT
Created attachment 191641 [details]
rpm-spec-mode as a real compilation mode

I've been working on changing rpm-spec-mode to use a real compilation mode.  I
think this is a better way to fix the problem than to patch up the existing,
rather kludgey version.  Compare, for example, grep.el.

Chip
Comment 4 Jens Petersen 2007-10-15 01:37:34 EDT
I just noticed this too after upgrading the latest emacs package for F7. :-(
Comment 5 Jens Petersen 2007-10-15 01:51:49 EDT
Re-bytecompiling rpm-spec-mode.el by hand seems to fix the problem.
Not sure why it is broken or if rpm-spec-mode.el should require cl-macs at
compile time.
Comment 6 Jens Petersen 2007-10-15 01:56:15 EDT
Ah I see there is bug 306841 for ignore-errors.
Comment 7 Laurent Rineau 2007-11-14 13:32:44 EST
(In reply to comment #3)
> Created an attachment (id=191641) [edit]
> rpm-spec-mode as a real compilation mode

Great!

Note: I had to add "(require 'compile)" at the beginning of the file. Without 
it, `define-compilation-mode was not known by Emacs.

I am look forward to see that file in Fedora...
Comment 8 Chip Coldwell 2007-11-28 08:49:23 EST

*** This bug has been marked as a duplicate of 227418 ***
Comment 9 Chip Coldwell 2007-11-28 10:23:54 EST
Created attachment 271411 [details]
rpm-spec-mode using a real compilation mode

Here's a first cut at an rpm-spec-mode that uses a real compilation mode.  Give
it a try and report any bugs.

One thing that I know work is signing rpms automagically after build.

Chip
Comment 10 Laurent Rineau 2007-11-28 10:47:35 EST
Tested once.(In reply to comment #9)
> Created an attachment (id=271411) [edit]
> rpm-spec-mode using a real compilation mode
> 
> Here's a first cut at an rpm-spec-mode that uses a real compilation mode.  
Give
> it a try and report any bugs.

Tested once. Works fine. I have added it to my load path, and will test 
regularly.

RPM signing does *not* work.
Comment 11 Chip Coldwell 2007-11-28 11:05:47 EST
(In reply to comment #10)
> 
> RPM signing does *not* work.

Yes, that was what I meant to say in my previous, mangled comment.

Once we've worked out all the bugs and have all the functionality back, I want
to push this change upstream.  It seems logical to me that rpm building should
be done in a compilation buffer.

Chip



Note You need to log in before you can comment on or make changes to this bug.