Bug 2495869 - Review Request: rust-ink-stroke-modeler-rs - Library for smoothing freehand input
Summary: Review Request: rust-ink-stroke-modeler-rs - Library for smoothing freehand i...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/ink-stroke-m...
Whiteboard:
Depends On:
Blocks: 2426985
TreeView+ depends on / blocked
 
Reported: 2026-07-01 09:32 UTC by Milan Crha
Modified: 2026-07-02 13:51 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-07-02 13:51:40 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
rust2rpm.toml (185 bytes, text/plain)
2026-07-01 10:36 UTC, Milan Crha
no flags Details

Description Milan Crha 2026-07-01 09:32:18 UTC
Spec URL: https://mcrha.fedorapeople.org/rust-ink-stroke-modeler-rs.spec
SRPM URL: https://mcrha.fedorapeople.org/rust-ink-stroke-modeler-rs-0.1.0-1.fc45.src.rpm
Upstream URL: https://crates.io/crates/ink-stroke-modeler-rs

Description:
Unofficial and partial Rust rewrite of ink-stroke-modeler, a C++ library
for beautifully smoothing freehand (touch/stylus/pointer) input.

Fedora Account System Username: mcrha

Comment 1 Milan Crha 2026-07-01 09:32:21 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=147263365

Comment 2 Fedora Review Service 2026-07-01 09:36:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10667525
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2495869-rust-ink-stroke-modeler-rs/fedora-rawhide-x86_64/10667525-rust-ink-stroke-modeler-rs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Milan Crha 2026-07-01 10:36:10 UTC
Created attachment 2147273 [details]
rust2rpm.toml

Comment 4 Fabio Valentini 2026-07-02 12:28:54 UTC
Package was generated with rust2rpm, simplifying the review.

There are a bunch of files (justfile, todo.md, docs/*) that could be excluded from the built packages, but they all seem to be OK from a "distributable" perspective and don't cause any problems, so whether or not to do that is up to you (there's a "package.exclude-crate-files" setting in rust2rpm.toml for this kind of situation) and since the package looks OK as-is I won't block the review on it.

The patch is justified and documented (the "svg" dependency is only used for the included example application, so it can be dropped safely).

The license files are in a location / have file names that aren't correctly recognized by rust2rpm, the settings for overriding that heuristic are correctly used.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 5 Fedora Admin user for bugzilla script actions 2026-07-02 13:04:02 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ink-stroke-modeler-rs
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 6 Fedora Update System 2026-07-02 13:48:54 UTC
FEDORA-2026-b9caf1fa8f (rust-ink-stroke-modeler-rs-0.1.0-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-b9caf1fa8f

Comment 7 Fedora Update System 2026-07-02 13:51:40 UTC
FEDORA-2026-b9caf1fa8f (rust-ink-stroke-modeler-rs-0.1.0-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.