Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/emape/fx/srpm-builds/10681573/fx.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/emape/fx/srpm-builds/10681573/fx-39.2.0-1.fc44.src.rpm Description: Terminal JSON viewer & processor Fedora Account System Username: emape Hi, this is my first package and I am looking for a sponsor. The original package was written in Node.js and has since been retired. It has now been ported to Go for a few years and I would like to add it to the Fedora packages again. I am not the author of the tool, just a user. I created the SRPM with the help of Mikel Olasagasti from this devel thread[0]. [0]: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/4OWRPSS3RJ5IENNWAQB57BCWDAC2BBUS/
Copr build: https://copr.fedorainfracloud.org/coprs/build/10681812 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497055-fx/fedora-rawhide-x86_64/10681812-fx/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/fx Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hey, Emanuele. Please upload the files to somewhere with persistent storage. COPR deletes the files after a couple of days and both your links are now 404.
Hi Artur, I have re-uploaded the files to Fedora People. Spec URL: https://emape.fedorapeople.org/fx.spec SRPM URL: https://emape.fedorapeople.org/fx-39.2.0-1.fc44.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/10767824 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497055-fx/fedora-rawhide-x86_64/10767824-fx/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/fx Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> %doc README.md RELEASE.md npm/README.md You can drop npm/README.md before importing. Golang Package Review ============== This package was generated using go2rpm and Go Vendor Tools, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. - [-] GO_LDFLAGS are set correctly. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance