Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://mikel.olasagasti.info/tmp/fedora/libcoraza.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/libcoraza-1.6.0-1.fc44.src.rpm Description: OWASP Coraza C connector. Fedora Account System Username: mikelo2
Copr build: https://copr.fedorainfracloud.org/coprs/build/10684184 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497176-libcoraza/fedora-rawhide-x86_64/10684184-libcoraza/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Do you still need that reviewed and would you like to review mine package at https://bugzilla.redhat.com/show_bug.cgi?id=2564281 ? Anyway here is a quick review: 1) version 1.6.0 is not the latest one anymore 2) %gobuild -buildmode=c-archive -o libcoraza.a libcoraza/coraza.go libcoraza/log.go Do you need to build libcoraza.a? You don't seem to reference it later on. 3) patchelf --set-soname libcoraza.so.1 libcoraza.so Could you add a comment what is in DT_SONAME and why you need to change it?