Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 249728

Summary:	xenbus has use-after-free in drivers/xen/xenbus/xenbus_xs.c
Product:	Red Hat Enterprise Linux 5	Reporter:	Don Dutile (Red Hat) <ddutile>
Component:	kernel-xen	Assignee:	Don Dutile (Red Hat) <ddutile>
Status:	CLOSED ERRATA	QA Contact:	Martin Jenner <mjenner>
Severity:	low	Docs Contact:
Priority:	low
Version:	5.0	CC:	xen-maint
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	RHBA-2008-0314	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-05-21 14:47:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	249727
Bug Blocks:

Description Don Dutile (Red Hat) 2007-07-26 18:18:41 UTC

+++ This bug was initially created as a clone of Bug #249727 +++

Description of problem:

The Coverity checker spotted the following use-after-free
in drivers/xen/xenbus/xenbus_xs.c:

<--  snip  -->
...
static int process_msg(void)
{
...
               if (IS_ERR(msg->u.watch.vec)) {
                       kfree(msg);
                       err = PTR_ERR(msg->u.watch.vec);
...

<--  snip  -->


Version-Release number of selected component (if applicable): 4.5


How reproducible:
Would need to exhaust system memory to generate a ENOMEM while performing
xenstore access by xenbus driver

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 RHEL Program Management 2007-07-26 18:24:29 UTC

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 2 Don Dutile (Red Hat) 2007-12-12 21:13:08 UTC

Posted patch that is simple copy/port of:

http://xenbits.xensource.com/xen-3.1-testing.hg?rev/20284e9cd540

Comment 4 Don Zickus 2007-12-21 20:17:23 UTC

in 2.6.18-62.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 7 errata-xmlrpc 2008-05-21 14:47:15 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0314.html