Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://eseyman.fedorapeople.org/perl-B-Hooks-AtRuntime/perl-B-Hooks-AtRuntime.spec SRPM URL: https://eseyman.fedorapeople.org/perl-B-Hooks-AtRuntime/perl-B-Hooks-AtRuntime-8-14.fc44.src.rpm Description: This module allows code that runs at compile-time to do something at runtime. A block passed to at_runtime gets compiled into the code that's currently compiling, and will be called when control reaches that point at runtime. In the example in the SYNOPSIS, the warnings will occur in order, and if that section of code runs more than once, so will all three warnings. Fedora Account System Username: eseyman
Copr build: https://copr.fedorainfracloud.org/coprs/build/10690469 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497531-perl-b-hooks-atruntime/fedora-rawhide-x86_64/10690469-perl-B-Hooks-AtRuntime/fedora-review/review.txt Found issues: - Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/perl-B-Hooks-AtRuntime Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-B-Hooks-AtRuntime-8-14.fc45.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit) 1 perl(Carp) 1 perl(constant) 1 perl(Exporter::Tiny) 1 perl-libs 1 perl(:MODULE_COMPAT_5.42.2) 1 perl(parent) 1 perl(strict) 1 perl(Sub::Name) 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-B-Hooks-AtRuntime-8-14.fc45.x86_64.rpm | sort | uniq -c 1 perl(B::Hooks::AtRuntime) = 8 1 perl-B-Hooks-AtRuntime = 8-14.fc45 1 perl-B-Hooks-AtRuntime(x86-64) = 8-14.fc45 Binary provides are Ok. $ rpmlint ./perl-B-Hooks-AtRuntime* perl-B-Hooks-AtRuntime.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/auto/B/Hooks/AtRuntime/AtRuntime.bs 2 packages and 1 specfiles checked; 1 errors, 0 warnings, 8 filtered, 1 badness; has taken 0.4 s FIX: Remove the zero-length .bs file. Add to %install section: find %{buildroot} -type f -name '*.bs' -empty -delete TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please consider fixing 'FIX' and 'TODO' items. Resolution: Approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-B-Hooks-AtRuntime Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
(In reply to Jitka Plesnikova from comment #2) > > FIX: Remove the zero-length .bs file. Add to %install section: > find %{buildroot} -type f -name '*.bs' -empty -delete Done. > TODO: Explicitly name packaged files in %{_mandir}/man* and > %{perl_vendorlib} directories > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Done. > Resolution: > Approved Thank you, Jikta. I have unretired the package and imported the new spec: https://koji.fedoraproject.org/koji/buildinfo?buildID=3033729