Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/dhandzus/mariadb-connector-python/srpm-builds/10717091/mariadb-connector-python.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dhandzus/mariadb-connector-python/srpm-builds/10717091/mariadb-connector-python-1.1.14-1.fc45.src.rpm Description: MariaDB Connector/Python enables python programs to access MariaDB and MySQL databases, using an API which is compliant with the Python DB API 2.0 (PEP-249). It is written in C and uses MariaDB Connector/C client library for client server communication. Fedora Account System Username:dhandzus
Spec URL: https://download.copr.fedorainfracloud.org/results/dhandzus/mariadb-connector-python/srpm-builds/10717751/mariadb-connector-python.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dhandzus/mariadb-connector-python/srpm-builds/10717751/mariadb-connector-python-1.1.14-2.fc45.src.rpm
[fedora-review-service-build]
This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License v2.1 or later", "*No copyright* GNU Library General Public License v2 or later", "GNU Library General Public License v2 or later", "*No copyright* Creative Commons Attribution 3.0 and/or GNU Lesser General Public License, Version 2.1". 72 files have unknown license. Detailed output of licensecheck in /tmp/review_manual/2499975-mariadb- connector-python/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python3.15, /usr/lib64/python3.15/site-packages [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2487 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [-]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mariadb-connector-python-1.1.14-2.fc45.x86_64.rpm mariadb-connector-python-1.1.14-2.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpttn7fv9r')] checks: 32, packages: 2 mariadb-connector-python.x86_64: E: incorrect-fsf-address /usr/lib64/python3.15/site-packages/mariadb-1.1.14.dist-info/licenses/LICENSE mariadb-connector-python.x86_64: E: incorrect-fsf-address /usr/share/licenses/mariadb-connector-python/LICENSE 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 7 filtered, 2 badness; has taken 0.2 s Rpmlint (debuginfo) ------------------- Checking: mariadb-connector-python-debuginfo-1.1.14-2.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfkwtkryg')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 mariadb-connector-python.x86_64: E: incorrect-fsf-address /usr/lib64/python3.15/site-packages/mariadb-1.1.14.dist-info/licenses/LICENSE mariadb-connector-python.x86_64: E: incorrect-fsf-address /usr/share/licenses/mariadb-connector-python/LICENSE 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 9 filtered, 2 badness; has taken 0.3 s Unversioned so-files -------------------- mariadb-connector-python: /usr/lib64/python3.15/site-packages/mariadb/_mariadb.cpython-315-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/mariadb-corporation/mariadb-connector-python/archive/refs/tags/v1.1.14.tar.gz : CHECKSUM(SHA256) this package : 1f1e973d40e56eda859370597fbf7d3d96b9c2d4da2c20e85ad17dae38aae79b CHECKSUM(SHA256) upstream package : 1f1e973d40e56eda859370597fbf7d3d96b9c2d4da2c20e85ad17dae38aae79b Requires -------- mariadb-connector-python (rpmlib, GLIBC filtered): libc.so.6()(64bit) libmariadb.so.3()(64bit) libmariadb.so.3(libmariadb_3)(64bit) libmariadb.so.3(libmysqlclient_18)(64bit) python(abi) python3.15dist(packaging) rtld(GNU_HASH) Provides -------- mariadb-connector-python: mariadb-connector-python mariadb-connector-python(x86-64) python-mariadb python3-mariadb python3.15-mariadb python3.15dist(mariadb) python3dist(mariadb) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2499975 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Python, Shell-api Disabled plugins: Haskell, R, Ocaml, SugarActivity, PHP, fonts, Java, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
> mariadb-connector-python.x86_64: E: incorrect-fsf-address /usr/lib64/python3.15/site-packages/mariadb-1.1.14.dist-info/licenses/LICENSE > mariadb-connector-python.x86_64: E: incorrect-fsf-address /usr/share/licenses/mariadb-connector-python/LICENSE This error is triggered solely by an outdated FSF mailing address printed in the header of the upstream LICENSE files. The actual legal terms are correct and the source license texts are verbatim to the official https://spdx.org/licenses/LGPL-2.1-or-later.html.
LGTM
I will sponsor Daniel as part of the https://pagure.io/packager-sponsors/issue/779
> Unversioned so-files > -------------------- > mariadb-connector-python: /usr/lib64/python3.15/site-packages/mariadb/_mariadb.cpython-315-x86_64-linux-gnu.so This .so is unversioned because it is a Python C-extension loaded at runtime, and is not meant to be linked against by other system binaries and/or users. According to Fedora packaging guidelines, unversioned so-files are acceptable under the following conditions: 1. The DSO MUST NOT be visible to the dynamic linker - the .so is not visible in the ldconfig -p output. 2. DSO must be located in a private directory (not directly in /usr/lib64/) - the .so is installed within the Python site-packages/ subdirectory. 3. DSO must not be linked against and is loaded at runtime by the implementing application - it is loaded solely at runtime by Python via import. Because these conditions are met, the unversioned DSO does not need to be placed in -devel package.
LGTM, thank you for checking
The Pagure repository was created at https://src.fedoraproject.org/rpms/mariadb-connector-python Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`