spec file link is not working, but you can get it from next to the srpm: https://download.copr.fedorainfracloud.org/results/matiasv/rust-smbios-lib/fedora-43-x86_64/10702842-rust-smbios-lib/rust-smbios-lib.spec

Can you add a new comment with that link? It helps tools like `fedora-review`

You should also add fedora 44 and fedora rawhide chroots to your copr build and make sure it passes there. Building on rawhide is the required piece for new packages

spec file has a comment about rust2rpm 25 which is quite old. Make sure you are using rust2rpm 28 which is latest version available in all stable fedora AFAICT

https://download.copr.fedorainfracloud.org/results/matiasv/rust-smbios-lib/fedora-43-x86_64/10702842-rust-smbios-lib/rust-smbios-lib.spec

https://download.copr.fedorainfracloud.org/results/matiasv/rust-smbios-lib/fedora-43-x86_64/10737504-rust-smbios-lib/rust-smbios-lib.spec

When posting updated packaging, please use formatting something like

spec URL: X
srpm URL: Y

src.rpm is often a necessary component since it contains any patches, if there are custom patches. But I found the srpm so we are good.

The spec file has `License: FIXME`. License value for this case should be

  License: MIT AND (MIT OR Apache-2.0) AND (Unlicense OR MIT)

(Look for `BEGIN LICENSE SUMMARY` in the build output and then AND those together to get that value)

Besides that, the only difference in the spec from stock rust2rpm output is disabling tests that aren't expected to pass, which is fine.
Hopefully those are covered by a rust2rpm.toml config so it's easy to reproduce on future updates.

I confirmed this builds and installs on rawhide, so it all looks good. Just post with fixed license tag and I'll approve.

Hmm ok another thing I noticed. There's an `smbios-lib` subpackage which actually only contains one binary, `smbiosdump`. If you don't need that binary for your needs, I'd suggest adding `cargo-install-bin = false` to rust2rpm.toml. It can be added later if anyone cares. But if you want to distribute the binary, use bin-package-name='smbiosdump' in rust2rpm.toml, so that package is named more appropriately

spec URL: https://download.copr.fedorainfracloud.org/results/matiasv/rust-smbios-lib/fedora-43-x86_64/10738482-rust-smbios-lib/rust-smbios-lib.spec

srpm URL: https://download.copr.fedorainfracloud.org/results/matiasv/rust-smbios-lib/fedora-43-x86_64/10738482-rust-smbios-lib/rust-smbios-lib-0.9.3-1.fc43.src.rpm


An SMBIOS Library created in Rust that reads and parses raw BIOS data.

It supports DMTF System Management BIOS (SMBIOS) Reference Specification 3.7.0
on Linux, macOS, and Windows.

Upstream: https://github.com/jrgerber/smbios-lib
Crates.io: https://crates.io/crates/smbios-lib

Successful Copr build: https://copr.fedorainfracloud.org/coprs/matiasv/rust-smbios-lib/builds/

I need this crate packaged as a dependency for another project I am working on
(libcryptsetup-token-tdx-kbs).

Reproducible: Always

rust2rpm.toml:
``` 
[package]
cargo-install-bin = false

[tests]
run = ["lib", "bins"]
skip = ["unix::platform::tests::test_dev_mem_scan"]
comments = ["Integration tests and test_dev_mem_scan require access to /dev/mem and /sys/firmware which are unavailable in build environments"]
```

+ spec is rust2rpm + rust2rpm.toml output without any manual changes
+ builds on rawhide
+ installs on rawhide
+ content looks fine
 
setting fedora-review+

I can sponsor you, I'll follow up for that

Ok you are in the packager group now. I think we just wait for package creation process to happen

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-smbios-lib
Monitoring:
Anitya project is accessible by this link 
`https://release-monitoring.org/project/391274`
 you can modify it manually.
Package was created in Anitya

FYI, the project that was created ↑ here was broken, I fixed it:
https://release-monitoring.org/project/391274/

Not sure what caused wrong settings to get used for it.