Fedora Account System
Red Hat Associate
Red Hat Customer
Created attachment 2149099 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-char_str.spec SRPM URL: https://music.fedorapeople.org/rust-char_str-0.0.2-1.fc44.src.rpm Description: Compact owned string types forked from lean_string for Ruff and ty. Fedora Account System Username: music This is a new dependency for the latest version of ty (and presumably the upcoming version of ruff).
Created attachment 2149178 [details] Configuration file for rust2rpm Updated to hide the “salsa” feature for now; I’ll expose it in the future when ruff/ty use it, at which point will have aligned it on the same version of salsa that ruff/ty use. Re-uploaded to the same URLs.
Standard rust package and patches make sense. APPROVED Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 51 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/rust- char_str/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- char_str-devel , rust-char_str+default-devel , rust- char_str+arbitrary-devel , rust-char_str+get-size-devel , rust- char_str+serde-devel , rust-char_str+std-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: rust-char_str-devel-0.0.2-1.fc45.noarch.rpm rust-char_str+default-devel-0.0.2-1.fc45.noarch.rpm rust-char_str+arbitrary-devel-0.0.2-1.fc45.noarch.rpm rust-char_str+get-size-devel-0.0.2-1.fc45.noarch.rpm rust-char_str+serde-devel-0.0.2-1.fc45.noarch.rpm rust-char_str+std-devel-0.0.2-1.fc45.noarch.rpm rust-char_str-0.0.2-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpti5l9e1r')] checks: 32, packages: 7 rust-char_str+arbitrary-devel.noarch: E: spelling-error ('ty', 'Summary(en_US) ty -> Ty, t, y') rust-char_str+arbitrary-devel.noarch: E: spelling-error ('ty', '%description -l en_US ty -> Ty, t, y') rust-char_str+default-devel.noarch: E: spelling-error ('ty', 'Summary(en_US) ty -> Ty, t, y') rust-char_str+default-devel.noarch: E: spelling-error ('ty', '%description -l en_US ty -> Ty, t, y') rust-char_str+get-size-devel.noarch: E: spelling-error ('ty', 'Summary(en_US) ty -> Ty, t, y') rust-char_str+get-size-devel.noarch: E: spelling-error ('ty', '%description -l en_US ty -> Ty, t, y') rust-char_str+serde-devel.noarch: E: spelling-error ('ty', 'Summary(en_US) ty -> Ty, t, y') rust-char_str+serde-devel.noarch: E: spelling-error ('ty', '%description -l en_US ty -> Ty, t, y') rust-char_str+std-devel.noarch: E: spelling-error ('ty', 'Summary(en_US) ty -> Ty, t, y') rust-char_str+std-devel.noarch: E: spelling-error ('ty', '%description -l en_US ty -> Ty, t, y') rust-char_str.src: E: spelling-error ('ty', 'Summary(en_US) ty -> Ty, t, y') rust-char_str.src: E: spelling-error ('ty', '%description -l en_US ty -> Ty, t, y') rust-char_str-devel.noarch: E: spelling-error ('ty', 'Summary(en_US) ty -> Ty, t, y') rust-char_str-devel.noarch: E: spelling-error ('ty', '%description -l en_US ty -> Ty, t, y') 7 packages and 0 specfiles checked; 14 errors, 0 warnings, 37 filtered, 14 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "rust-char_str+default-devel". (none): E: there is no installed rpm "rust-char_str+get-size-devel". (none): E: there is no installed rpm "rust-char_str+arbitrary-devel". (none): E: there is no installed rpm "rust-char_str+serde-devel". (none): E: there is no installed rpm "rust-char_str+std-devel". (none): E: there is no installed rpm "rust-char_str-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/char_str/0.0.2/download#/char_str-0.0.2.crate : CHECKSUM(SHA256) this package : 576ba56f6ca18ebb069d0d07260407171712aff4dfe15ee3f8982dc16a455bcf CHECKSUM(SHA256) upstream package : 576ba56f6ca18ebb069d0d07260407171712aff4dfe15ee3f8982dc16a455bcf Requires -------- rust-char_str-devel (rpmlib, GLIBC filtered): (crate(castaway) >= 0.2.4 with crate(castaway) < 0.3.0~) (crate(castaway/alloc) >= 0.2.4 with crate(castaway/alloc) < 0.3.0~) (crate(itoa/default) >= 1.0.0 with crate(itoa/default) < 2.0.0~) (crate(ryu/default) >= 1.0.0 with crate(ryu/default) < 2.0.0~) cargo rust-char_str+default-devel (rpmlib, GLIBC filtered): cargo crate(char_str) crate(char_str/std) rust-char_str+arbitrary-devel (rpmlib, GLIBC filtered): (crate(arbitrary) >= 1.0.0 with crate(arbitrary) < 2.0.0~) cargo crate(char_str) rust-char_str+get-size-devel (rpmlib, GLIBC filtered): (crate(get-size2/default) >= 0.10.0 with crate(get-size2/default) < 0.11.0~) cargo crate(char_str) crate(char_str/std) rust-char_str+serde-devel (rpmlib, GLIBC filtered): (crate(serde_core) >= 1.0.0 with crate(serde_core) < 2.0.0~) cargo crate(char_str) rust-char_str+std-devel (rpmlib, GLIBC filtered): cargo crate(char_str) Provides -------- rust-char_str-devel: crate(char_str) purl(pkg:cargo/char_str.2) rust-char_str-devel rust-char_str+default-devel: crate(char_str/default) rust-char_str+default-devel rust-char_str+arbitrary-devel: crate(char_str/arbitrary) rust-char_str+arbitrary-devel rust-char_str+get-size-devel: crate(char_str/get-size) rust-char_str+get-size-devel rust-char_str+serde-devel: crate(char_str/serde) rust-char_str+serde-devel rust-char_str+std-devel: crate(char_str/std) rust-char_str+std-devel Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-char_str --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: fonts, C/C++, Python, R, Perl, Java, Ocaml, SugarActivity, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you very much for the review! https://release-monitoring.org/project/391300/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-char_str Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-2ffd0d35c2 (rust-char_str-0.0.2-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-2ffd0d35c2
FEDORA-2026-2ffd0d35c2 (rust-char_str-0.0.2-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.