Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://lecris.fedorapeople.org/reviews/pyclibrary/pyclibrary.spec SRPM URL: https://lecris.fedorapeople.org/reviews/pyclibrary/pyclibrary-0.3.0-1.fc45.src.rpm Description: C parser and bindings automation for Python. Fork of https://launchpad.net/pyclibrary. Fedora Account System Username: lecris
Copr build: https://copr.fedorainfracloud.org/coprs/build/10748171 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2502106-pyclibrary/fedora-rawhide-x86_64/10748171-pyclibrary/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The URL should use https. You may also want to tell upstream that they don't need wheel in their build-system.requires. Why is the source package not named python-pyclibrary? Is the license not already included in the build (pass -l to %pyproject_save_files)?
Indeed so, probably was a bit too jet-lagged when I was doing this one. For context this one I was doing as part of https://copr.fedorainfracloud.org/coprs/lecris/cuda-example/, still valid to include on our side though. I think the wheel part will fix it once upstream decides on a path. There is something funky because in the `MANIFEST.in` we are not supposed to have the test files, but we clearly do. Spec URL: https://lecris.fedorapeople.org/reviews/python-pyclibrary/python-pyclibrary.spec SRPM URL: https://lecris.fedorapeople.org/reviews/python-pyclibrary/python-pyclibrary-0.3.0-1.fc46.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=149196274
Copr build: https://copr.fedorainfracloud.org/coprs/build/10871262 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2502106-python-pyclibrary/fedora-rawhide-x86_64/10871262-python-pyclibrary/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Please fix the URL and s/python/Python/ in the Summary before import. APPROVED.