Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Text-Markdown-Discount.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Text-Markdown-Discount-0.18-1.fc45.src.rpm Description: Text::Markdown::Discount is a perl interface to the Discount library, a C implementation of John Gruber's markdown. Fedora Account System Username: xavierb
Copr build: https://copr.fedorainfracloud.org/coprs/build/10757475 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2502711-perl-text-markdown-discount/fedora-rawhide-x86_64/10757475-perl-Text-Markdown-Discount/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
URL and Source0 are ok Source0 archive (SHA-224:3dc98c697e737391b8570ef2440f825f5a2cf268dc6b9ebbe8843ecb) is original. Ok. License verified from lib/Text/Markdown/Discount.pm is ok. TODO: Upstream should be contacted to let them know that their LICENSE file is out of date (the FSF no longer has a physical address). Summary is ok. Description is ok BuildRequires are ok FIX: Add 'coreutils' to BRs (needed for %{_fixperms}) FIX: Add 'findutils' to BRs (needed for find) FIX: Add 'sed' to BRs (needed for sed) $ rpm -qp --requires perl-Text-Markdown-Discount-0.18-1.* | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit) 1 libmarkdown.so.2()(64bit) 1 perl(Exporter) 1 perl-libs 1 perl(:MODULE_COMPAT_5.44.0) 1 perl(strict) 1 perl(:VERSION) >= 5.8.1 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) 1 perl(Text::Markdown::Discount) = 0.18 1 perl-Text-Markdown-Discount = 0.18-1.fc45 1 perl-Text-Markdown-Discount(x86-64) = 0.18-1.fc45 Binary requires are Ok. $ rpm -qp --provides perl-Text-Markdown-Discount-0.18-1.*| sort | uniq -c 1 perl(Text::Markdown::Discount) = 0.18 1 perl-Text-Markdown-Discount = 0.18-1.fc45 1 perl-Text-Markdown-Discount(x86-64) = 0.18-1.fc45 Binary provides are Ok. $ rpmlint perl-Text-Markdown-Discount* perl-Text-Markdown-Discount.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Text-Markdown-Discount/LICENSE Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct 'FIX' items and consider fixing the 'TODO' item. Resolution: Approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Text-Markdown-Discount Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`