Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-CLI-Simple.spec SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-CLI-Simple-2.0.14-1.fc45.src.rpm Description: Tired of writing the same 'ol boilerplate code for command line scripts? Want a standard, simple way to create a Perl script that takes options and commands? CLI::Simple makes it easy to create scripts that take options, commands and arguments. Fedora Account System Username: xavierb
Copr build: https://copr.fedorainfracloud.org/coprs/build/10757476 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2502712-perl-cli-simple/fedora-rawhide-x86_64/10757476-perl-CLI-Simple/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed TODO: Since you've submitted the package for review, upstream has released several versions. Please update your package ASAP. BuildRequires are ok TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST only appears from this version onwards. $ rpm -qp --requires perl-CLI-Simple-2.0.14-1.fc45.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(Class::Accessor::Fast) 1 perl(CLI::Simple) 1 perl(CLI::Simple::Constants) 1 perl(CLI::Simple::DumpSpec) 1 perl(CLI::Simple::Helpers) 1 perl(CLI::Simple::Migrate) 1 perl(CLI::Simple::Scaffold) 1 perl(CLI::Simple::Shell) 1 perl(CLI::Simple::Utils) 1 perl(Cwd) 1 perl(Data::Dumper) 1 perl(English) 1 perl(Exporter) 1 perl(File::Basename) 1 perl(File::ShareDir) >= 1.118 1 perl(File::Which) 1 perl(FindBin) 1 perl(Getopt::Long) 1 perl(JSON) 1 perl-libs 1 perl(List::Util) 1 perl(Log::Log4perl) 1 perl(Log::Log4perl::Level) 1 perl(parent) 1 perl(Pod::Usage) 1 perl(Readonly) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 perl(YAML::Tiny) >= 1.76 1 /usr/bin/bash Binary requires are Ok. $ rpm -qp --provides perl-CLI-Simple-2.0.14-1.fc45.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(CLI::Simple) = 2.0.14 1 perl-CLI-Simple = 2.0.14-1.fc45 1 perl(CLI::Simple::Constants) = 2.0.14 1 perl(CLI::Simple::DumpSpec) 1 perl(CLI::Simple::Helpers) 1 perl(CLI::Simple::Migrate) 1 perl(CLI::Simple::Modulino) 1 perl(CLI::Simple::Scaffold) 1 perl(CLI::Simple::Shell) 1 perl(CLI::Simple::Utils) = 2.0.14 Binary provides are Ok. $ rpmlint ./perl-CLI-Simple* perl-CLI-Simple.noarch: E: spelling-error ('ol', '%description -l en_US ol -> lo, pl, o') perl-CLI-Simple.src: E: spelling-error ('ol', '%description -l en_US ol -> lo, pl, o') perl-CLI-Simple.noarch: W: no-manual-page-for-binary create-modulino perl-CLI-Simple.noarch: W: dangling-relative-symlink /usr/share/man/man3/cli-simple.3pm.gz ../CLI::Simple.3pm.gz ========== 2 packages and 1 specfiles checked; 2 errors, 2 warnings, 8 filtered, 2 badness; has taken 0.2 s ========== The package is in line with Fedora and Perl packaging guide lines. Please consider fixing the 'TODO' item. Resolution: Approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-CLI-Simple Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Thanks for the review, both TODOs fixed, imported and Rawhide build done.