Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/matiasv/libcryptsetup-token-kbs/fedora-rawhide-x86_64/10792337-libcryptsetup-token-kbs/libcryptsetup-token-kbs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/matiasv/libcryptsetup-token-kbs/srpm-builds/10792337/libcryptsetup-token-kbs-2.0.0-1.fc37.src.rpm Description: LUKS2 external token plugin that unlocks encrypted volumes via TEE attestation against a Key Broker Service (KBS). Tested with Intel TDX but compatible with any TEE supported by trustee-attester. Also ships repart-kbs-helper, a first-boot attestation helper used by systemd-repart to obtain the LUKS encryption key. Upstream: https://github.com/MatiasVara/libcryptsetup-token-kbs License: GPL-3.0-or-later Successful Copr build: https://copr.fedorainfracloud.org/coprs/matiasv/libcryptsetup-token-kbs/builds/ Fedora Account: matiasv I am the upstream maintainer of this project.
rust package but not using rust2rpm so we are off the beaten path here, but the structure looks ok to me. builds and installs fine on rawhide. Only other examples of cryptsetup plugins I found in fedora come from systemd-udev and cryptsetup-ssh-token. But doesn't look like there's anything special besides dropping an .so, that this seems fine. Issues: + License: needs to contain the condensed output of LICENSE.dependencies, basically what was done for previous rust crate review. Can use `license-validate` to double check your License: string. + use %{__cc} instead of gcc + big one that needs testing: the default fedora build flags aren't used. see `rpm --eval '%{build_cflags}'` and `rpm --eval '%{build_ldflags}'`. Possibly some of those will conflict with the special flags you need for building the .so, but append additional options as needed to get the output working. best IMO for packaging would fix the Makefile up to be well behaved, so that this just works: %set_build_flags %make_build YOUR_TARGET_NAME (and possible %make_install for the %install section too)
Spec URL: https://download.copr.fedorainfracloud.org/results/matiasv/libcryptsetup-token-kbs/fedora-rawhide-x86_64/10807863-libcryptsetup-token-kbs/libcryptsetup-token-kbs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/matiasv/libcryptsetup-token-kbs/srpm-builds/10807863/libcryptsetup-token-kbs-2.0.0-1.fc37.src.rpm Description: LUKS2 external token plugin that unlocks encrypted volumes via TEE attestation against a Key Broker Service (KBS). Tested with Intel TDX but compatible with any TEE supported by trustee-attester. Also ships repart-kbs-helper, a first-boot attestation helper used by systemd-repart to obtain the LUKS encryption key. Upstream: https://github.com/MatiasVara/libcryptsetup-token-kbs License: GPL-3.0-or-later Successful Copr build: https://copr.fedorainfracloud.org/coprs/matiasv/libcryptsetup-token-kbs/builds/ Fedora Account: matiasv I am the upstream maintainer of this project.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10807889 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2509218-libcryptsetup-token-kbs/fedora-rawhide-x86_64/10807889-libcryptsetup-token-kbs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me now, setting fedora-review+
The Pagure repository was created at https://src.fedoraproject.org/rpms/libcryptsetup-token-kbs Monitoring: Anitya project is accessible by this link `https://release-monitoring.org/project/391651` you can modify it manually. Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`.