Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://raw.githubusercontent.com/phoebehfharris/rust-qrcode-fedora/refs/heads/main/rust-qrcode.spec SRPM URL: https://github.com/phoebehfharris/rust-qrcode-fedora/releases/download/review/rust-qrcode-0.14.1-2.fc45.src.rpm Description: QR code encoder in Rust Fedora Account System Username: phoebeharris
Copr build: https://copr.fedorainfracloud.org/coprs/build/10805364 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2510148-rust-qrcode/fedora-rawhide-x86_64/10805364-rust-qrcode/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-qrcode Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
A few minor things: The license summary from the build.log is: ### BEGIN LICENSE SUMMARY ### # BSD-3-Clause OR Apache-2.0 # MIT OR Apache-2.0 # Unlicense OR MIT # Zlib OR Apache-2.0 OR MIT ### END LICENSE SUMMARY ### These all need to be reflected by the License tag in the "qrcode" subpackage. Alternatively, if you aren't even packaging this for the command-line application, you can drop it (see package.cargo-install-bin = false setting, check "man rust2rpm.toml" for more info). It might also be a good idea to drop the *.png, *.pic, and *.svg files from src/* and examples/*, they appear to only be test input and aren't needed when using this crate as a library.
Have amended with the changes suggested: https://github.com/phoebehfharris/rust-qrcode-fedora/releases/download/review-2/rust-qrcode-0.14.1-3.fc46.src.rpm https://github.com/phoebehfharris/rust-qrcode-fedora/releases/download/review-2/rust-qrcode.spec