Bug 2511085 - Review Request: rust-wnaf - WNAF (w-ary non-adjacent form) variable-time scalar multiplication
Summary: Review Request: rust-wnaf - WNAF (w-ary non-adjacent form) variable-time scal...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/wnaf
Whiteboard:
Depends On: 2483508 2483860
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-08-04 16:23 UTC by Ben Beasley
Modified: 2026-08-19 21:44 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-08-19 21:44:39 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
Configuration file for rust2rpm (562 bytes, text/plain)
2026-08-04 16:23 UTC, Ben Beasley
no flags Details

Description Ben Beasley 2026-08-04 16:23:44 UTC
Created attachment 2153583 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-wnaf.spec
SRPM URL: https://music.fedorapeople.org/rust-wnaf-0.14.0-1.fc45.src.rpm

Description:

WNAF (w-ary non-adjacent form) variable-time scalar multiplication
implemented generically over elliptic curve groups with full `no_alloc`
support, including multiscalar multiplication using Straus's interleaved
window method. Contains an implementation adapted from the `group` crate
which has been forked and enhanced but is otherwise compatible with that
crate's traits, along with the `ff` crate's traits for finite field
representations.

Fedora Account System Username: music

Comment 1 Fedora Review Service 2026-08-04 16:26:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10812021
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2511085-rust-wnaf/fedora-rawhide-x86_64/10812021-rust-wnaf/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fedora Review Service 2026-08-04 16:26:43 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10812020
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2511085-rust-wnaf/fedora-rawhide-x86_64/10812020-rust-wnaf/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Ben Beasley 2026-08-04 16:51:25 UTC
COPR build with fedora-review enabled: https://copr.fedorainfracloud.org/coprs/music/reqsign/build/10812019/

Comment 4 Fabio Valentini 2026-08-18 14:53:31 UTC
There appears to be a discrepancy between the plain spec file URL and the SRPM:

-Summary:        WNAF (w-ary non-adjacent form) variable-time scalar multiplication
+Summary:        WNAF

Looks like one has a "fixed" summary, and the other one has the Summary badly mangled by rust2rpm heuristics.

Other than that, package looks good to me. Just make sure the "correct" one gets imported.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 5 Ben Beasley 2026-08-19 20:23:01 UTC
Thank you for the review!

https://release-monitoring.org/project/391838/

I will ensure the committed spec file has the “fixed” summary.

Comment 6 Fedora Admin user for bugzilla script actions 2026-08-19 20:23:46 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wnaf
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 7 Fedora Update System 2026-08-19 20:45:05 UTC
FEDORA-2026-47df84745d (rust-wnaf-0.14.0-1.fc46) has been submitted as an update to Fedora 46.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-47df84745d

Comment 8 Fedora Update System 2026-08-19 20:51:09 UTC
FEDORA-2026-aa1f5ef1ae (rust-wnaf-0.14.0-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-aa1f5ef1ae

Comment 9 Fedora Update System 2026-08-19 21:44:39 UTC
FEDORA-2026-47df84745d (rust-wnaf-0.14.0-1.fc46) has been pushed to the Fedora 46 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2026-08-19 21:44:43 UTC
FEDORA-2026-aa1f5ef1ae (rust-wnaf-0.14.0-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.