Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://fabio.fedorapeople.org/reviews/markdownlint-cli2/markdownlint-cli2.spec SRPM URL: https://fabio.fedorapeople.org/reviews/markdownlint-cli2/markdownlint-cli2-0.23.2-1.fc45.src.rpm Description: A command-line interface for linting Markdown/CommonMark files with the markdownlint library. Fedora Account System Username: fabio
Copr build: https://copr.fedorainfracloud.org/coprs/build/10832877 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2511720-markdownlint-cli2/fedora-rawhide-x86_64/10832877-markdownlint-cli2/fedora-review/review.txt Found issues: - License file LICENSE-MIT is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Fedora Review Service from comment #1) > Copr build: > https://copr.fedorainfracloud.org/coprs/build/10832877 > (succeeded) > > Review template: > https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora- > review-2511720-markdownlint-cli2/fedora-rawhide-x86_64/10832877-markdownlint- > cli2/fedora-review/review.txt > > Found issues: > > - License file LICENSE-MIT is not marked as %license > Read more: > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > LicensingGuidelines/#_license_text > > Please know that there can be false-positives. The LICENSE-MIT file is part of bundled Node.js modules, as stated in https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/ it's enough to: - listed in the license tag - list in the markdownlint-cli2-0.23.2-bundled-licenses.txt prepared by the nodejs-packaging-bundler This is a false-positive. > --- > This comment was created by the fedora-review-service > https://github.com/FrostyX/fedora-review-service > > If you want to trigger a new Copr build, add a comment containing new > Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10833246 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2511720-markdownlint-cli2/fedora-rawhide-x86_64/10833246-markdownlint-cli2/fedora-review/review.txt Found issues: - License file LICENSE-MIT is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package looks good. I only found one question for you: Is this dot directory needed? The rpmlint output found it installed: markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/reusify/.github markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/reusify/.github Not a huge deal... but it could be cleaned up.
(In reply to Michael Cronenworth from comment #4) > Package looks good. I only found one question for you: Is this dot directory > needed? The rpmlint output found it installed: > > markdownlint-cli2.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/markdownlint-cli2/node_modules/reusify/.github > markdownlint-cli2.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/markdownlint-cli2/node_modules/reusify/.github > > Not a huge deal... but it could be cleaned up. I've removed it. Spec URL: https://fabio.fedorapeople.org/reviews/markdownlint-cli2/2/markdownlint-cli2.spec SRPM URL: https://fabio.fedorapeople.org/reviews/markdownlint-cli2/2/markdownlint-cli2-0.23.2-1.fc46.src.rpm
Created attachment 2155159 [details] The .spec file difference from Copr build 10833246 to 10885712
Copr build: https://copr.fedorainfracloud.org/coprs/build/10885712 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2511720-markdownlint-cli2/fedora-rawhide-x86_64/10885712-markdownlint-cli2/fedora-review/review.txt Found issues: - License file LICENSE-MIT is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks great. Good job! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE-MIT is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 753 files have unknown license. Detailed output of licensecheck in /home/michael/Projects/fedora/review/markdownlint- cli2/2511720-markdownlint-cli2/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 35633 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: markdownlint-cli2-0.23.2-1.fc46.noarch.rpm markdownlint-cli2-0.23.2-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpoacz1jee')] checks: 32, packages: 2 markdownlint-cli2.noarch: W: only-non-binary-in-usr-lib markdownlint-cli2.noarch: W: no-manual-page-for-binary markdownlint-cli2 markdownlint-cli2.spec: W: invalid-url Source1: markdownlint-cli2-0.23.2-nm-prod.tgz markdownlint-cli2.spec: W: invalid-url Source2: markdownlint-cli2-0.23.2-nm-dev.tgz markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/.bin markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/.bin markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/.package-lock.json markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/markdownlint/schema/.markdownlint.jsonc markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/markdownlint/schema/.markdownlint.yaml 2 packages and 0 specfiles checked; 0 errors, 9 warnings, 489 filtered, 0 badness; has taken 1.0 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.10.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 33, packages: 1 markdownlint-cli2.noarch: W: only-non-binary-in-usr-lib markdownlint-cli2.noarch: W: no-manual-page-for-binary markdownlint-cli2 markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/.bin markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/.bin markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/.package-lock.json markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/markdownlint/schema/.markdownlint.jsonc markdownlint-cli2.noarch: W: hidden-file-or-dir /usr/lib/node_modules/markdownlint-cli2/node_modules/markdownlint/schema/.markdownlint.yaml 1 packages and 0 specfiles checked; 0 errors, 7 warnings, 485 filtered, 0 badness; has taken 0.4 s Source checksums ---------------- https://github.com/DavidAnson/markdownlint-cli2/archive/v0.23.2/markdownlint-cli2-0.23.2.tar.gz : CHECKSUM(SHA256) this package : 73cc7467df55e8ad6b16cc038b1aece21e99ebd59b1eed79c3274bb68af713dc CHECKSUM(SHA256) upstream package : 73cc7467df55e8ad6b16cc038b1aece21e99ebd59b1eed79c3274bb68af713dc Requires -------- markdownlint-cli2 (rpmlib, GLIBC filtered): /usr/bin/node nodejs(engine) Provides -------- markdownlint-cli2: bundled(nodejs-@nodelib/fs.scandir) bundled(nodejs-@nodelib/fs.stat) bundled(nodejs-@nodelib/fs.walk) bundled(nodejs-@sindresorhus/merge-streams) bundled(nodejs-@types/debug) bundled(nodejs-@types/katex) bundled(nodejs-@types/ms) bundled(nodejs-@types/unist) bundled(nodejs-ansi-regex) bundled(nodejs-argparse) bundled(nodejs-braces) bundled(nodejs-character-entities) bundled(nodejs-character-entities-legacy) bundled(nodejs-character-reference-invalid) bundled(nodejs-commander) bundled(nodejs-debug) bundled(nodejs-decode-named-character-reference) bundled(nodejs-dequal) bundled(nodejs-devlop) bundled(nodejs-entities) bundled(nodejs-fast-glob) bundled(nodejs-fastq) bundled(nodejs-fill-range) bundled(nodejs-get-east-asian-width) bundled(nodejs-glob-parent) bundled(nodejs-globby) bundled(nodejs-ignore) bundled(nodejs-is-alphabetical) bundled(nodejs-is-alphanumerical) bundled(nodejs-is-decimal) bundled(nodejs-is-extglob) bundled(nodejs-is-glob) bundled(nodejs-is-hexadecimal) bundled(nodejs-is-number) bundled(nodejs-is-path-inside) bundled(nodejs-js-yaml) bundled(nodejs-jsonc-parser) bundled(nodejs-jsonpointer) bundled(nodejs-katex) bundled(nodejs-linkify-it) bundled(nodejs-markdown-it) bundled(nodejs-markdownlint) bundled(nodejs-markdownlint-cli2-formatter-default) bundled(nodejs-mdurl) bundled(nodejs-merge2) bundled(nodejs-micromark) bundled(nodejs-micromark-core-commonmark) bundled(nodejs-micromark-extension-directive) bundled(nodejs-micromark-extension-gfm-autolink-literal) bundled(nodejs-micromark-extension-gfm-footnote) bundled(nodejs-micromark-extension-gfm-table) bundled(nodejs-micromark-extension-math) bundled(nodejs-micromark-factory-destination) bundled(nodejs-micromark-factory-label) bundled(nodejs-micromark-factory-space) bundled(nodejs-micromark-factory-title) bundled(nodejs-micromark-factory-whitespace) bundled(nodejs-micromark-util-character) bundled(nodejs-micromark-util-chunked) bundled(nodejs-micromark-util-classify-character) bundled(nodejs-micromark-util-combine-extensions) bundled(nodejs-micromark-util-decode-numeric-character-reference) bundled(nodejs-micromark-util-encode) bundled(nodejs-micromark-util-html-tag-name) bundled(nodejs-micromark-util-normalize-identifier) bundled(nodejs-micromark-util-resolve-all) bundled(nodejs-micromark-util-sanitize-uri) bundled(nodejs-micromark-util-subtokenize) bundled(nodejs-micromark-util-symbol) bundled(nodejs-micromark-util-types) bundled(nodejs-micromatch) bundled(nodejs-ms) bundled(nodejs-parse-entities) bundled(nodejs-picomatch) bundled(nodejs-punycode.js) bundled(nodejs-queue-microtask) bundled(nodejs-reusify) bundled(nodejs-run-parallel) bundled(nodejs-slash) bundled(nodejs-smol-toml) bundled(nodejs-string-width) bundled(nodejs-strip-ansi) bundled(nodejs-to-regex-range) bundled(nodejs-uc.micro) bundled(nodejs-unicorn-magic) markdownlint-cli2 npm(markdownlint-cli2) Diff spec file in url and in SRPM --------------------------------- --- /home/michael/Projects/fedora/review/markdownlint-cli2/2511720-markdownlint-cli2/srpm/markdownlint-cli2.spec 2026-08-23 20:55:23.447251489 -0500 +++ /home/michael/Projects/fedora/review/markdownlint-cli2/2511720-markdownlint-cli2/srpm-unpacked/markdownlint-cli2.spec 2026-08-19 19:00:00.000000000 -0500 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.4) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global npm_name markdownlint-cli2 @@ -99,3 +109,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Thu Aug 20 2026 John Doe <packager> - 0.23.2-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2511720 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, Haskell, SugarActivity, Perl, Ocaml, PHP, Java, Python, fonts, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/markdownlint-cli2 Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-1ec7d4b944 (markdownlint-cli2-0.23.2-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-1ec7d4b944
FEDORA-2026-80617a4ee6 (markdownlint-cli2-0.23.2-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-80617a4ee6
FEDORA-2026-8979783510 (markdownlint-cli2-0.23.2-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-8979783510
FEDORA-2026-8979783510 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-8979783510 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-8979783510 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-1ec7d4b944 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-1ec7d4b944 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-1ec7d4b944 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-80617a4ee6 has been pushed to the Fedora 45 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-80617a4ee6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-80617a4ee6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-8979783510 (markdownlint-cli2-0.23.2-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-1ec7d4b944 (markdownlint-cli2-0.23.2-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.