Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://github.com/Alex-Muir/rust-plotters-backend/blob/main/rust-plotters-backend.spec SRPM URL: https://github.com/Alex-Muir/rust-plotters-backend/blob/main/rust-plotters-backend-0.3.7-1.fc45.src.rpm Successful Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=148941662 Description: This is a part of Plotters, the Rust drawing and plotting library. This is used as the connector between Plotters and different backend crates. Fedora Account System Username: scone-crusher This is one of the many dependencies required to eventually package GNOME Resources. This is my first package submission. I will need a sponsor. For prospective sponsors: I have made some small contributions to Fedora in the recent past. A few wiki edits here: https://fedoraproject.org/w/index.php?title=SIGs/Python&action=history and one upstream pull request for argparse-manpage during Python 3.15 integration ( https://github.com/praiskup/argparse-manpage/pull/130 ), although my code change to argparse-manpage was added by someone else in the Python SIG since my PR was not merged before the dealine.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10843849 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2513647-rust-plotters-backend/srpm-builds/10843849/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://raw.githubusercontent.com/Alex-Muir/rust-plotters-backend/main/rust-plotters-backend.spec SRPM URL: https://raw.githubusercontent.com/Alex-Muir/rust-plotters-backend/main/rust-plotters-backend-0.3.7-1.fc45.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/10851064 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2513647-rust-plotters-backend/fedora-rawhide-x86_64/10851064-rust-plotters-backend/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-plotters-backend Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This looks good, with one exception: It looks like the crate was published on a system that doesn't support symbolic links (usually Windows without symbolic link support turned on): The "LICENSE" file contains the literal string "../LICENSE" instead of the MIT license text. With the MIT license requiring that redistributed sources contain a copy of the original license text, this is a blocker for the review. Please report this as a bug with the upstream project (https://github.com/plotters-rs/plotters). You can use <https://crates.io/crates/plotters-backend/0.3.7/code/LICENSE> as a public link where this issue is apparent.
Upstream bug report: https://github.com/plotters-rs/plotters/issues/743