Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://skim.cz/tmp/perl-DBD-ODBC/perl-DBD-ODBC.spec SRPM URL: https://skim.cz/tmp/perl-DBD-ODBC/perl-DBD-ODBC-1.61-13.fc45.src.rpm Description: This module is needed to access ODBC databases from within Perl. The module uses the unixODBC manager to connect to the database. Fedora Account System Username: mspacek
There seems to be some problem with the following file. SRPM URL: https://skim.cz/tmp/perl-DBD-ODBC/perl-DBD-ODBC-1.61-13.fc45.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://mspacek.fedorapeople.org/perl-DBD-ODBC/perl-DBD-ODBC.spec SRPM URL: https://mspacek.fedorapeople.org/perl-DBD-ODBC/perl-DBD-ODBC-1.61-13.fc45.src.rpm Description: This module is needed to access ODBC databases from within Perl. The module uses the unixODBC manager to connect to the database. Fedora Account System Username: mspacek
Copr build: https://copr.fedorainfracloud.org/coprs/build/10883613 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2513838-perl-dbd-odbc/fedora-rawhide-x86_64/10883613-perl-DBD-ODBC/fedora-review/review.txt Found issues: - Explicit dependency on perl-devel is not allowed unless building architecture-specific code which links to libperl.so Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/ - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/perl-DBD-ODBC Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed (database tests skipped because DBI_DSN is undefined, which is expected without a live ODBC data source) BuildRequires: FIX: Add build-require 'coreutils' - it is needed for %{_fixperms}. $ rpm -qp --requires perl-DBD-ODBC-1.61-13.fc46.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.3)(64bit) 1 libc.so.6(GLIBC_2.38)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit) 1 libodbc.so.2()(64bit) 1 libperl.so.5.44()(64bit) 1 perl(constant) 1 perl(DBI) >= 1.609 1 perl(DynaLoader) 1 perl(Exporter) 1 perl-libs 1 perl(:MODULE_COMPAT_5.44.0) 1 perl(strict) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) 1 rtld(GNU_HASH) 1 unixODBC Binary requires are Ok. $ rpm -qp --provides perl-DBD-ODBC-1.61-13.fc46.x86_64.rpm | sort | uniq -c 1 perl(DBD::ODBC) 1 perl-DBD-ODBC = 1.61-13.fc46 1 perl-DBD-ODBC(x86-64) = 1.61-13.fc46 Binary provides are Ok. $ rpmlint ./perl-DBD-ODBC* perl-DBD-ODBC.src: E: spelling-error ('unixODBC', '%description -l en_US') perl-DBD-ODBC.x86_64: E: spelling-error ('unixODBC', '%description -l en_US') 2 packages and 1 specfiles checked; 2 errors, 0 warnings, 8 filtered, 2 badness; has taken 0.8 s Note: The spelling error is a false positive - unixODBC is a product name. TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorarch} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. TODO: Please consider to add examples to documentation. Don't forget to remove execute bit. Please consider fixing 'FIX' and 'TODO' items. Resolution: Approved
Thanks you.
Package was unretired: https://forge.fedoraproject.org/releng/fedora-scm-requests/issues/363