Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://mripard.fedorapeople.org/srpms/python-liblore.spec SRPM URL: https://mripard.fedorapeople.org/srpms/python-liblore-0.8.1-1.fc45.src.rpm Description: A Python library for working with public-inbox servers, particularly lore.kernel.org. It fetches email threads, parses mbox files, and provides utilities for working with email messages from mailing list archives. Fedora Account System Username: mripard
A copr build can be found here https://copr.fedorainfracloud.org/coprs/mripard/python-liblore/
Copr build: https://copr.fedorainfracloud.org/coprs/build/10845645 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2513852-python-liblore/fedora-rawhide-x86_64/10845645-python-liblore/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The fedora-review tools warns of some issues with this package request: ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: liblore-0.8.1-1.fc45.noarch.rpm python-liblore-0.8.1-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpb0f8x90t')] checks: 32, packages: 2 liblore.noarch: E: spelling-error ('mbox', '%description -l en_US mbox -> box, m box') python-liblore.src: E: spelling-error ('mbox', '%description -l en_US mbox -> box, m box') liblore.noarch: E: incorrect-fsf-address /usr/lib/python3.15/site-packages/liblore-0.8.1.dist-info/licenses/LICENSES/GPL-2.0-or-later.txt 2 packages and 0 specfiles checked; 3 errors, 0 warnings, 7 filtered, 3 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 liblore.noarch: E: spelling-error ('mbox', '%description -l en_US mbox -> box, m box') liblore.noarch: E: incorrect-fsf-address /usr/lib/python3.15/site-packages/liblore-0.8.1.dist-info/licenses/LICENSES/GPL-2.0-or-later.txt 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 3 filtered, 2 badness; has taken 0.0 s
I indeed modified a comment in the spec file after building the srpm. I didn't realise it was an issue, sorry. The spec file can be found here: https://download.copr.fedorainfracloud.org/results/mripard/python-liblore/srpm-builds/10852809/python-liblore.spec And SRPM https://download.copr.fedorainfracloud.org/results/mripard/python-liblore/srpm-builds/10852809/python-liblore-0.8.1-1.fc46.src.rpm For the other error and warnings, it all looks like it comes from the source code itself. Is it something we're expected to fix?
Created attachment 2154402 [details] The .spec file difference from Copr build 10845645 to 10862338
Copr build: https://copr.fedorainfracloud.org/coprs/build/10862338 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2513852-python-liblore/fedora-rawhide-x86_64/10862338-python-liblore/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
for the mbox warning, one can add a lint exception using an rpmlintrc file $ rpmlint -e spelling-error spelling-error: The value of this tag appears to be misspelled. Please double-check. For the FSF address, just let upstream know or better yet, send a patch with the updated license text to change: https://git.kernel.org/pub/scm/utils/liblore/liblore.git/tree/LICENSES/GPL-2.0-or-later.txt $ rpmlint -e incorrect-fsf-address incorrect-fsf-address: The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. https://docs.fedoraproject.org/en-US/package-maintainers/CommonRpmlintIssues/#incorrect_fsf_address
Thanks for the guidance. I reported the FSF address issue upstream here: https://lore.kernel.org/tools/20260814-vengeful-smooth-pronghorn-cc6ded@houat/ And I've added a rpmlint filter to not report a warning on mbox. The new spec file is here: https://download.copr.fedorainfracloud.org/results/mripard/python-liblore/srpm-builds/10865067/python-liblore.spec and srpm: https://download.copr.fedorainfracloud.org/results/mripard/python-liblore/srpm-builds/10865067/python-liblore-0.8.1-1.fc46.src.rpm
Created attachment 2154507 [details] The .spec file difference from Copr build 10862338 to 10865112
Copr build: https://copr.fedorainfracloud.org/coprs/build/10865112 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2513852-python-liblore/fedora-rawhide-x86_64/10865112-python-liblore/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.