Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://jjames.fedorapeople.org/gap-pkg-orbitalgraphs/gap-pkg-orbitalgraphs.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-orbitalgraphs/gap-pkg-orbitalgraphs-0.1.2%5E20260711.0255d71-1.fc46.src.rpm Fedora Account System Username: jjames Description: This package contains some utilities to compute with and research orbital graphs in GAP. I am willing to swap reviews.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10866473 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2516180-gap-pkg-orbitalgraphs/fedora-rawhide-x86_64/10866473-gap-pkg-orbitalgraphs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= The documentation package does nor install due to a missing dependency: Failed to resolve the transaction: Problem: conflicting requests - nothing provides gap-pkg-backtrackkit-doc >= 1.1.0 needed by gap-pkg-orbitalgraphs-doc-0.1.2^20260711.0255d71-1.fc46.noarch from @commandline This will be provided by a different package currently under review. Make sure the packages are introduced in Fedora in the correct order. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 579 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. Note: a git commit is package due to lack of tags upstream [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. Build only tested on x86_64 -- but it is a noarch package [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- As mentioned above - the doc package depends on an other package currently in review. Rpmlint ------- Checking: gap-pkg-orbitalgraphs-0.1.2^20260711.0255d71-1.fc46.noarch.rpm gap-pkg-orbitalgraphs-doc-0.1.2^20260711.0255d71-1.fc46.noarch.rpm gap-pkg-orbitalgraphs-0.1.2^20260711.0255d71-1.fc46.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4h60ssae')] checks: 32, packages: 3 gap-pkg-orbitalgraphs-doc.noarch: W: no-documentation gap-pkg-orbitalgraphs-doc.noarch: W: hidden-file-or-dir /usr/share/gap/pkg/OrbitalGraphs/notebooks/.ipynb_checkpoints gap-pkg-orbitalgraphs-doc.noarch: W: hidden-file-or-dir /usr/share/gap/pkg/OrbitalGraphs/notebooks/.ipynb_checkpoints gap-pkg-orbitalgraphs-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/OrbitalGraphs/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-orbitalgraphs-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/OrbitalGraphs/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-orbitalgraphs-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/OrbitalGraphs/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-orbitalgraphs-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/OrbitalGraphs/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-orbitalgraphs-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/OrbitalGraphs/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-orbitalgraphs-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/OrbitalGraphs/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-orbitalgraphs-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/OrbitalGraphs/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-orbitalgraphs-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/OrbitalGraphs/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-orbitalgraphs-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/OrbitalGraphs/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-orbitalgraphs-doc.noarch: W: dangling-relative-symlink /usr/share/gap/pkg/OrbitalGraphs/doc/toggless.js ../../GAPDoc/styles/toggless.js 3 packages and 0 specfiles checked; 0 errors, 13 warnings, 12 filtered, 0 badness; has taken 0.2 s Source checksums ---------------- https://github.com/gap-packages/OrbitalGraphs/archive/0255d714b5bb8d8e7a3e3f8332df9bbd11f35b8a/OrbitalGraphs-0255d71.tar.gz : CHECKSUM(SHA256) this package : 5d1389e23c8dc7b2e9998941d16f2d75c06b10ab73577f6659cb5bc310ec9f75 CHECKSUM(SHA256) upstream package : 5d1389e23c8dc7b2e9998941d16f2d75c06b10ab73577f6659cb5bc310ec9f75 Requires -------- gap-pkg-orbitalgraphs (rpmlib, GLIBC filtered): gap(digraphs) gap-core gap-pkg-orbitalgraphs-doc (rpmlib, GLIBC filtered): gap-online-help gap-pkg-backtrackkit-doc gap-pkg-digraphs-doc gap-pkg-orbitalgraphs Provides -------- gap-pkg-orbitalgraphs: gap(OrbitalGraphs) gap(orbitalgraphs) gap-pkg-orbitalgraphs gap-pkg-orbitalgraphs-doc: gap-pkg-orbitalgraphs-doc Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2516180 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: fonts, Haskell, PHP, SugarActivity, C/C++, Python, R, Perl, Java, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Argh, that dependency on gap-pkg-backtrackkit-doc was a copy & paste error. I removed it: Spec URL: https://jjames.fedorapeople.org/gap-pkg-orbitalgraphs/gap-pkg-orbitalgraphs.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-orbitalgraphs/gap-pkg-orbitalgraphs-0.1.2%5E20260711.0255d71-1.fc46.src.rpm