Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://jjames.fedorapeople.org/rust-cpu-time/rust-cpu-time.spec SRPM URL: https://jjames.fedorapeople.org/rust-cpu-time/rust-cpu-time-1.0.0-1.fc46.src.rpm Fedora Account System Username: jjames Description: Small crate that provides CPU time measurement. I am willing to swap reviews.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10866475 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2516182-rust-cpu-time/fedora-rawhide-x86_64/10866475-rust-cpu-time/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. This is almost 100% boilerplate and a very small library (though quite old, with the last release having been in 2019 and no git activity since). I would recommend not to make manual modifications that cannot be encoded in rust2rpm.toml config file (like adding the "VCS" tag), but if you want to keep manually adding this every time you have to re-run rust2rpm in the future, you are free to do so. It might be nice to drop the files that are unused for build / packaging purposes (appveyor.yml, bulk.yaml, vagga.yaml, .travis.yml), but they don't *hurt* when included in the built package - see "package" / "exclude-crate-files" docs in "man rust2rpm.toml". ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
Thank you for the review! This is my first rust package, so I appreciate the pointers. I will create rust2rpm.toml as suggested to exclude the unnecessary files.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cpu-time Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-e2998ef30a (rust-cpu-time-1.0.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-e2998ef30a
FEDORA-2026-e2998ef30a has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-e2998ef30a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-e2998ef30a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-e2998ef30a (rust-cpu-time-1.0.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.