Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://decathorpe.fedorapeople.org/oo7.spec SRPM URL: https://decathorpe.fedorapeople.org/oo7-0.7.0~alpha-1.fc44.src.rpm Upstream URL: https://github.com/linux-credentials/oo7 Description: Secret Service provider. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=149224000
Note: One thing I was not sure about was the inter-dependencies between the packages. The only "hard" dependencies seem to be pam_oo7 -> oo7-daemon (and possibly oo7-portal -> oo7-daemon). It looks like the other components communicate over the Secret Service DBus API and for that it doesn't really matter which thing is on the other end, as far as I can tell, so I didn't add hard dependencies from oo7-cli and the git and cargo credential helpers to oo7-daemon.
Taking this review.
Initial spec review: > %build > # oo7-daemon > pushd server > %meson > %meson_build > popd > > # oo7-pam > pushd pam > %meson > %meson_build > popd > > # oo7-portal > pushd portal > %meson > %meson_build > popd Can we please split this into %conf and %build phases? I know it's a bit much, but I think it's worth it to at least leverage the three phases properly.
Would that look like this? ``` %conf # oo7-daemon pushd server %meson popd # oo7-pam pushd pam %meson popd # oo7-portal pushd portal %meson popd %build # oo7-daemon pushd server %meson_build popd # oo7-pam pushd pam %meson_build popd # oo7-portal pushd portal %meson_build popd ``` This ... feels unnecessarily verbose.
Yes, it would look like that. (It boggles the mind why there isn't a top-level meson.build, but whatever...)
Alright, done. Files behind the same URLs have updated contents.
Review notes: * Package follows Fedora Packaging Guidelines * Package follows Fedora Rust packaging guidelines * Package licensing is correct and license files are installed correctly * Package builds and installs * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/oo7 Monitoring: Anitya project is accessible by this link `https://release-monitoring.org/project/375085` you can modify it manually. Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`.
Thank you for the review. Package imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2026-bfecfe5c45 (F45 build still running.)