Spec URL: http://developer.postgresql.org/~devrim/rpms/other/kpogre/kpogre.spec SRPM URL: http://developer.postgresql.org/~devrim/rpms/other/kpogre/kpogre-1.5.4-1.fc7.src.rpm Description: KPoGre is graphical administration tool for PostgreSQL. It uses libpqxx library.
Quick tip for the reviewer: I could not test this package in mock -- so BRs and R's may be missing.
For a start, the source URL should be similar to: Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz Mock build fails with: checking for KDE... configure: error: in the prefix, you've chosen, are no KDE headers installed. This will fail. So, check this please and use another prefix! error: Bad exit status from /var/tmp/rpm-tmp.40521 (%prep) Adding kdelibs-devel solves this, but rpmlint exposes some more problems: E: kpogre standard-dir-owned-by-package /usr/share W: kpogre dangling-symlink /usr/share/doc/HTML/en/kpogre/common /usr/share/doc/HTML/en/common W: kpogre symlink-should-be-relative /usr/share/doc/HTML/en/kpogre/common /usr/share/doc/HTML/en/common E: kpogre standard-dir-owned-by-package /usr/bin E: kpogre standard-dir-owned-by-package /usr/share/doc E: kpogre standard-dir-owned-by-package /usr/share/icons -> you try to own directories that you should not W: kpogre invalid-license GPL -> The lists with the valid licenses is available at http://fedoraproject.org/wiki/Licensing#head-489bc5bbf14ecdb808316674e9fc465243cfa4f5 E: kpogre binary-or-shlib-defines-rpath /usr/bin/kpogre ['/usr/lib64', '/usr/lib64/qt-3.3/lib'] You should try to get rid of the rpath. See http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28rpath%29#head-a1dfb5f46bf4098841e31a75d833e6e1b3e72544
Hi, (In reply to comment #2) > For a start, the source URL should be similar to: > Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz > > Mock build fails with: > checking for KDE... configure: error: > in the prefix, you've chosen, are no KDE headers installed. This will fail. > So, check this please and use another prefix! > error: Bad exit status from /var/tmp/rpm-tmp.40521 (%prep) > Adding kdelibs-devel solves this, but rpmlint exposes some more problems: > E: kpogre standard-dir-owned-by-package /usr/share > W: kpogre dangling-symlink /usr/share/doc/HTML/en/kpogre/common > /usr/share/doc/HTML/en/common > W: kpogre symlink-should-be-relative /usr/share/doc/HTML/en/kpogre/common > /usr/share/doc/HTML/en/common > E: kpogre standard-dir-owned-by-package /usr/bin > E: kpogre standard-dir-owned-by-package /usr/share/doc > E: kpogre standard-dir-owned-by-package /usr/share/icons > -> you try to own directories that you should not > > W: kpogre invalid-license GPL > -> The lists with the valid licenses is available at > http://fedoraproject.org/wiki/Licensing#head-489bc5bbf14ecdb808316674e9fc465243cfa4f5 > > E: kpogre binary-or-shlib-defines-rpath /usr/bin/kpogre ['/usr/lib64', > '/usr/lib64/qt-3.3/lib'] > You should try to get rid of the rpath. All are done. Thanks for the review. I will post the new SRPM and the new spec file shortly.
New spec URL: http://developer.postgresql.org/~devrim/rpms/other/kpogre/kpogre.spec New SRPM URL: http://developer.postgresql.org/~devrim/rpms/other/kpogre/kpogre-1.5.4-2.fc7.src.rpm
I've updated a bit the spec (modified the license tag, added a BR for kdelibs3, sourced qt.h in %build) and tried a mock build. Unfortunately it fails. I have attached the modified spec and the build log
Created attachment 292302 [details] failed mock build /var/lib/mock//fedora-development-x86_64/result/build.log after mock bombs out with State Changed: setup ERROR: Exception(/home/wolfy/rpm/SRPMS/kpogre-1.5.4-3.fc7.src.rpm) Config(fedora-development-x86_64) 0 minutes 30 seconds INFO: Results and/or logs in: /var/lib/mock//fedora-development-x86_64/result
Created attachment 292303 [details] modified spec the modified spec
Comment on attachment 292302 [details] failed mock build sorry, wrong build log, please ignore it
Created attachment 292304 [details] failed mock build build log after mock fails
Hi, Could you please try the following SRPM? : http://developer.postgresql.org/~devrim/rpms/other/kpogre/kpogre-1.6.0-1.f8.src.rpm and the new spec is here: http://developer.postgresql.org/~devrim/rpms/other/kpogre/kpogre.spec Regards, DEvrim
Created attachment 292307 [details] failed mock build for 1.6.0-1 Still fails mock build here (rawhide, x86_64)
Created attachment 292308 [details] Build error of 1.6.0 This is the build error on Fedora-8.
So, anything new about fixing the errors in #9, #11 and #12 ?
ping ?
ping again ?
last ping before closing as dead-review
Since I got no reply from the submitter in more than 6 months, I am closing this. If anyone wishes to submit this application, please open a new review request.