Bug 251864 - Review Request: kpogre - PostgreSQL graphical frontend for KDE 3.x
Review Request: kpogre - PostgreSQL graphical frontend for KDE 3.x
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Extras Quality Assurance
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2007-08-12 17:35 EDT by Devrim GUNDUZ
Modified: 2008-08-08 13:06 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-08-08 13:00:24 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
failed mock build (33.55 KB, text/plain)
2008-01-20 19:15 EST, manuel wolfshant
no flags Details
modified spec (2.32 KB, text/plain)
2008-01-20 19:16 EST, manuel wolfshant
no flags Details
failed mock build (1.54 MB, application/octet-stream)
2008-01-20 19:19 EST, manuel wolfshant
no flags Details
failed mock build for 1.6.0-1 (709.67 KB, text/plain)
2008-01-20 20:38 EST, manuel wolfshant
no flags Details
Build error of 1.6.0 (3.92 KB, text/plain)
2008-01-20 20:47 EST, Devrim GUNDUZ
no flags Details

  None (edit)
Description Devrim GUNDUZ 2007-08-12 17:35:05 EDT
Spec URL: http://developer.postgresql.org/~devrim/rpms/other/kpogre/kpogre.spec
SRPM URL: http://developer.postgresql.org/~devrim/rpms/other/kpogre/kpogre-1.5.4-1.fc7.src.rpm
Description: 
KPoGre is graphical administration tool for PostgreSQL.
It uses libpqxx library.
Comment 1 Devrim GUNDUZ 2007-08-12 17:37:34 EDT
Quick tip for the reviewer: I could not test this package in mock -- so BRs and
R's may be missing.
Comment 2 manuel wolfshant 2007-08-12 20:46:53 EDT
For a start, the source URL should be similar to:
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz

Mock build fails with:
checking for KDE... configure: error:
in the prefix, you've chosen, are no KDE headers installed. This will fail.
So, check this please and use another prefix!
error: Bad exit status from /var/tmp/rpm-tmp.40521 (%prep)
Adding kdelibs-devel solves this, but rpmlint exposes some more problems:
E: kpogre standard-dir-owned-by-package /usr/share
W: kpogre dangling-symlink /usr/share/doc/HTML/en/kpogre/common
/usr/share/doc/HTML/en/common
W: kpogre symlink-should-be-relative /usr/share/doc/HTML/en/kpogre/common
/usr/share/doc/HTML/en/common
E: kpogre standard-dir-owned-by-package /usr/bin
E: kpogre standard-dir-owned-by-package /usr/share/doc
E: kpogre standard-dir-owned-by-package /usr/share/icons
-> you try to own directories that you should not

W: kpogre invalid-license GPL
-> The lists with the valid licenses is available at
http://fedoraproject.org/wiki/Licensing#head-489bc5bbf14ecdb808316674e9fc465243cfa4f5

E: kpogre binary-or-shlib-defines-rpath /usr/bin/kpogre ['/usr/lib64',
'/usr/lib64/qt-3.3/lib']
You should try to get rid of the rpath. See
http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28rpath%29#head-a1dfb5f46bf4098841e31a75d833e6e1b3e72544
Comment 3 Devrim GUNDUZ 2007-08-29 02:57:03 EDT
Hi,

(In reply to comment #2)
> For a start, the source URL should be similar to:
> Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
> 
> Mock build fails with:
> checking for KDE... configure: error:
> in the prefix, you've chosen, are no KDE headers installed. This will fail.
> So, check this please and use another prefix!
> error: Bad exit status from /var/tmp/rpm-tmp.40521 (%prep)
> Adding kdelibs-devel solves this, but rpmlint exposes some more problems:
> E: kpogre standard-dir-owned-by-package /usr/share
> W: kpogre dangling-symlink /usr/share/doc/HTML/en/kpogre/common
> /usr/share/doc/HTML/en/common
> W: kpogre symlink-should-be-relative /usr/share/doc/HTML/en/kpogre/common
> /usr/share/doc/HTML/en/common
> E: kpogre standard-dir-owned-by-package /usr/bin
> E: kpogre standard-dir-owned-by-package /usr/share/doc
> E: kpogre standard-dir-owned-by-package /usr/share/icons
> -> you try to own directories that you should not
> 
> W: kpogre invalid-license GPL
> -> The lists with the valid licenses is available at
>
http://fedoraproject.org/wiki/Licensing#head-489bc5bbf14ecdb808316674e9fc465243cfa4f5
> 
> E: kpogre binary-or-shlib-defines-rpath /usr/bin/kpogre ['/usr/lib64',
> '/usr/lib64/qt-3.3/lib']
> You should try to get rid of the rpath. 

All are done.

Thanks for the review. I will post the new SRPM and the new spec file shortly.


Comment 5 manuel wolfshant 2008-01-20 19:13:52 EST
I've updated a bit the spec (modified the license tag, added a BR for kdelibs3,
sourced qt.h in %build) and tried a mock build. Unfortunately it fails.
I have attached the modified spec and the build log
Comment 6 manuel wolfshant 2008-01-20 19:15:17 EST
Created attachment 292302 [details]
failed mock build

 /var/lib/mock//fedora-development-x86_64/result/build.log after mock bombs out
with 
State Changed: setup
ERROR: Exception(/home/wolfy/rpm/SRPMS/kpogre-1.5.4-3.fc7.src.rpm)
Config(fedora-development-x86_64) 0 minutes 30 seconds
INFO: Results and/or logs in: /var/lib/mock//fedora-development-x86_64/result
Comment 7 manuel wolfshant 2008-01-20 19:16:41 EST
Created attachment 292303 [details]
modified spec

the modified spec
Comment 8 manuel wolfshant 2008-01-20 19:17:59 EST
Comment on attachment 292302 [details]
failed mock build

sorry, wrong build log, please ignore it
Comment 9 manuel wolfshant 2008-01-20 19:19:48 EST
Created attachment 292304 [details]
failed mock build

build log after mock fails
Comment 10 Devrim GUNDUZ 2008-01-20 19:57:04 EST
Hi,

Could you please try the following SRPM? :

http://developer.postgresql.org/~devrim/rpms/other/kpogre/kpogre-1.6.0-1.f8.src.rpm

and the new spec is here:

http://developer.postgresql.org/~devrim/rpms/other/kpogre/kpogre.spec

Regards, DEvrim
Comment 11 manuel wolfshant 2008-01-20 20:38:16 EST
Created attachment 292307 [details]
failed mock build for 1.6.0-1

Still fails mock build here (rawhide, x86_64)
Comment 12 Devrim GUNDUZ 2008-01-20 20:47:52 EST
Created attachment 292308 [details]
Build error of 1.6.0

This is the build error on Fedora-8.
Comment 13 manuel wolfshant 2008-03-03 03:08:47 EST
So, anything new about fixing the errors in #9, #11 and #12 ?
Comment 14 manuel wolfshant 2008-03-21 21:35:12 EDT
ping ?
Comment 15 manuel wolfshant 2008-07-26 21:25:51 EDT
ping again ?
Comment 16 manuel wolfshant 2008-08-01 11:12:43 EDT
last ping before closing as dead-review
Comment 17 manuel wolfshant 2008-08-08 13:00:24 EDT
Since I got no reply from the submitter in more than 6 months, I am closing this.
If anyone wishes to submit this application, please open a new review request.

Note You need to log in before you can comment on or make changes to this bug.