Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/g3ntleli0n/hiera-gpg/srpm-builds/10872689/rubygem-hiera-eyaml.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/g3ntleli0n/hiera-gpg/srpm-builds/10872689/rubygem-hiera-eyaml-5.0.1-1.src.rpm Description: Hiera backend for decrypting encrypted yaml properties Fedora Account System Username: g3ntleli0n The package has been orphaned more than 8 weeks ago, which is why a new review is necessary. Note: I do need a package sponsor as I am not a fedora packager as of yet.
Requires: rubygem-optimist * The indentation of this line is inconsistent with the other lines in the header. * Why is this line here at all ? `Requires` should normally auto computed from the gemspec.... ? * I would say https://github.com/voxpupuli/hiera-eyaml/ was a better URL than the rubygems one since that is the package's homepage. I can sponsor you but do you have some informal reviews of other packages you could point me at or something?
* "Upstream" https://github.com/voxpupuli/hiera-eyaml/ contains features/ so please package this directory and execute "cucumber" testsuite on %check as much as possible if dependencies are available
Copr build: https://copr.fedorainfracloud.org/coprs/build/10882384 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2519469-rubygem-hiera-eyaml/fedora-rawhide-x86_64/10882384-rubygem-hiera-eyaml/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rubygem-hiera-eyaml Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Mamoru TASAKA from comment #2) > * "Upstream" https://github.com/voxpupuli/hiera-eyaml/ contains features/ so > please package this directory and execute "cucumber" testsuite on %check as > much as possible if dependencies are available Hey, thank you for the quick response. Upstream ships the 'features/' folder but the gem itself does not. I can add upstream as a second source to execute tests at runtime. It would require a lot of dependencies for most of the tests though some of which would have to be packaged separately for Fedora (For example: 'hiera-eyaml-plaintext'). I've got a lot of it to work locally, but when its missing dependencies, some of the tests naturally fail. How do you want me to proceed?
Please execute tests which can be runnable with dependencies which is currently available on Fedora. So for example, if all of the tests needs 'hiera-eyaml-plaintext' which is currently not available on Fedora, just comment so in the spec file and you can skip executing tests in this srpm. Or if some tests can be executed with dependency currently available on Fedora, try executing them (and skip other tests which are currently not runnable due to missing dependency).
(In reply to Steve Traylen from comment #1) > Requires: rubygem-optimist > > * The indentation of this line is inconsistent with the other lines in the > header. > * Why is this line here at all ? `Requires` should normally auto computed > from the gemspec.... ? > > * I would say https://github.com/voxpupuli/hiera-eyaml/ was a better URL > than the rubygems one since that is the package's homepage. > > I can sponsor you but do you have some informal reviews of other packages > you could point me at or something? Thanks for the feedback, I have adjusted the spec file according to your feedback and triggered a new build on copr. I do not have any informal reviews I could point you to, however I can provide you with a bunch of other packages that I have packaged such as: - https://github.com/TeluTrix/personal-rpms/blob/main/obsidian/obsidian.spec - https://github.com/stepping-stone/hiera-gpg-rpms/blob/main/rubygem-gpgme/rubygem-gpgme.spec - https://github.com/stepping-stone/hiera-gpg-rpms/blob/main/rubygem-hiera-eyaml-gpg/rubygem-hiera-eyaml-gpg.spec - https://github.com/stepping-stone/hiera-gpg-rpms/blob/main/rubygem-optimist/rubygem-optimist.spec - https://github.com/stepping-stone/hiera-gpg-rpms/blob/main/rubygem-ruby-gpg/rubygem-ruby-gpg.spec Any feedback on those is obviously also much appreciated!
(In reply to Mamoru TASAKA from comment #5) > Please execute tests which can be runnable with dependencies which is > currently available on Fedora. > So for example, if all of the tests needs 'hiera-eyaml-plaintext' which is > currently not available on Fedora, > just comment so in the spec file and you can skip executing tests in this > srpm. > > Or if some tests can be executed with dependency currently available on > Fedora, try executing them > (and skip other tests which are currently not runnable due to missing > dependency). Thanks for the quick feedback. To run the cucumber tests both hiera-eyaml-gpg as well as hiera-eyaml-plaintext are required. As both those dependencies are not available in Fedora, I have skipped the tests entirely and commented it accordingly.
(In reply to Fedora Review Service from comment #3) > Copr build: > https://copr.fedorainfracloud.org/coprs/build/10882384 > (succeeded) > > Review template: > https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora- > review-2519469-rubygem-hiera-eyaml/fedora-rawhide-x86_64/10882384-rubygem- > hiera-eyaml/fedora-review/review.txt > > Found issues: > > - A package with this name already exists. Please check > https://src.fedoraproject.org/rpms/rubygem-hiera-eyaml > Read more: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ > #_conflicting_package_names > > Please know that there can be false-positives. > > --- > This comment was created by the fedora-review-service > https://github.com/FrostyX/fedora-review-service > > If you want to trigger a new Copr build, add a comment containing new > Spec and SRPM URLs or [fedora-review-service-build] string. This is to be expected, as the package was present in the fedora repo in the past.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10897254 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2519469-rubygem-hiera-eyaml/fedora-rawhide-x86_64/10897254-rubygem-hiera-eyaml/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rubygem-hiera-eyaml Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.