Fedora Account System
Red Hat Associate
Red Hat Customer
Created attachment 2154908 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-icu_locale_fallback.spec SRPM URL: https://music.fedorapeople.org/rust-icu_locale_fallback-2.3.0-1.fc44.src.rpm Description: API for Locale Fallback algorithms. Fedora Account System Username: music A new crate in ICU4X 2.3. This is a little tricky to review because it can only be built together with the complete ICU4X 2.2→2.3 update, involving many crates. However: - I built this locally with the appropriate dependencies and used --postinstall to verify that there are no installability issues. - I built this in COPR with fedora-review enabled, https://copr.fedorainfracloud.org/coprs/music/icu4x-rawhide/build/10880939/, which These, plus inspection of the crate contents, should be enough for an informed review.
> - I built this in COPR with fedora-review enabled, https://copr.fedorainfracloud.org/coprs/music/icu4x-rawhide/build/10880939/, which *which gives you a fedora-review template*
https://release-monitoring.org/project/391856/
Copr build: https://copr.fedorainfracloud.org/coprs/build/10882667 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2519638-rust-icu_locale_fallback/fedora-rawhide-x86_64/10882667-rust-icu_locale_fallback/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10882668 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2519638-rust-icu_locale_fallback/fedora-rawhide-x86_64/10882668-rust-icu_locale_fallback/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. ingredients reports no issues: $ ingredients report icu_locale_fallback 2.3.0 summary: 0 fatal issues, 0 errors, 0 warnings scallion confirms license as Unicode-3.0: $ scallion crawl . ./LICENSE License: Unicode-3.0 (original text) Score: 0.956 Patches are documented and well-justified and OK to keep downstream-only. Though it might be possible to "fix" the "writable" dev-dependency by not making cargo strip it: - writeable = { path = "../../utils/writeable" } + writeable = { version = "0.6.4", path = "../../utils/writeable" } I do not know whether a change like this would be acceptable for upstream, but this is *how* you *could* fix this issue upstream. ✅❌❓🫤 ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass: doctests are skipped since they introduce a dependency loop, and realistically, they can only be feasibly run inside the upstream cargo workspace. ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
Thank you for the review! > I do not know whether a change like this would be acceptable for upstream, but this is *how* you *could* fix this issue upstream. I have had some success getting changes like this merged upstream, https://github.com/unicode-org/icu4x/pull/5537, but there is some nuance with how this interacts with their publication process and limitations in cargo itself, with a full discussion in https://github.com/unicode-org/icu4x/issues/7196. While simple cases like this one could probably be “fixed” straightforwardly upstream, there are enough traps and intractable cases around that I’ve generally stopped trying to fix “missing” dev-dependencies in ICU4X crates.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-icu_locale_fallback Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`